Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined test coverage #429

Merged
merged 17 commits into from
Sep 9, 2024
Merged

Combined test coverage #429

merged 17 commits into from
Sep 9, 2024

Conversation

prateekdefi
Copy link
Contributor

No description provided.

@prateekdefi prateekdefi marked this pull request as ready for review August 27, 2024 14:52
arjun-io
arjun-io previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@arjun-io arjun-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@prateekdefi prateekdefi changed the base branch from v2.3 to main August 28, 2024 05:40
@prateekdefi prateekdefi dismissed arjun-io’s stale review August 28, 2024 05:40

The base branch was changed.

@prateekdefi prateekdefi changed the base branch from main to v2.3 August 28, 2024 05:40
@prateekdefi
Copy link
Contributor Author

I am looking in why CI is not triggered for this PR.

@prateekdefi prateekdefi marked this pull request as draft August 28, 2024 14:38
@prateekdefi prateekdefi marked this pull request as ready for review August 29, 2024 05:14
@prateekdefi prateekdefi marked this pull request as draft August 30, 2024 10:49
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 2, 2024
@prateekdefi prateekdefi marked this pull request as ready for review September 2, 2024 08:19
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 3, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 3, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 3, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 3, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 3, 2024
@equilibria-xyz equilibria-xyz deleted a comment from github-actions bot Sep 3, 2024
@kbrizzle
Copy link
Collaborator

kbrizzle commented Sep 4, 2024

I don't see the perennial-verifier package under any of these, am I missing it somewhere or is that one missing?

@prateekdefi
Copy link
Contributor Author

I don't see the perennial-verifier package under any of these, am I missing it somewhere or is that one missing?

It is missing. perennial-deploy is also missing. These workspaces were not a part of the CI earlier as well so I ignored them. Would you like me to add these? @kbrizzle

@arjun-io
Copy link
Collaborator

arjun-io commented Sep 5, 2024

I don't see the perennial-verifier package under any of these, am I missing it somewhere or is that one missing?

It is missing. perennial-deploy is also missing. These workspaces were not a part of the CI earlier as well so I ignored them. Would you like me to add these? @kbrizzle

All packages except for perennial-deploy should be added 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

[Periphery] Test Coverage Report

Coverage after merging prateek/combined-test-coverage into v2.3 will be
99.32%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-account/contracts
   Account.sol100%100%100%100%
   AccountVerifier.sol100%100%100%100%
   Controller.sol100%100%100%100%
   Controller_Arbitrum.sol100%100%100%100%
   Controller_Incentivized.sol100%100%100%100%
packages/perennial-account/contracts/libs
   RebalanceLib.sol100%100%100%100%
packages/perennial-account/contracts/test
   RebalanceConfigTester.sol100%100%100%100%
packages/perennial-account/contracts/types
   Action.sol100%100%100%100%
   DeployAccount.sol100%100%100%100%
   MarketTransfer.sol100%100%100%100%
   RebalanceConfig.sol100%100%100%100%
   RebalanceConfigChange.sol100%100%100%100%
   RelayedAccessUpdateBatch.sol100%100%100%100%
   RelayedGroupCancellation.sol100%100%100%100%
   RelayedNonceCancellation.sol100%100%100%100%
   RelayedOperatorUpdate.sol100%100%100%100%
   RelayedSignerUpdate.sol100%100%100%100%
   Withdrawal.sol100%100%100%100%
packages/perennial-extensions/contracts
   Coordinator.sol100%100%100%100%
   MultiInvoker.sol100%100%100%100%
   MultiInvoker_Arbitrum.sol0%100%0%0%37, 45
   MultiInvoker_Optimism.sol0%100%0%0%37, 45
packages/perennial-extensions/contracts/types
   TriggerOrder.sol96.43%100%100%95.83%55
packages/perennial-oracle/contracts
   Oracle.sol100%100%100%100%
   OracleFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/chainlink
   ChainlinkFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper
   KeeperFactory.sol97.70%100%92.86%98.63%211
   KeeperOracle.sol97.33%100%94.12%98.28%84
packages/perennial-oracle/contracts/keeper/libs
   DedupLib.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper/types
   KeeperOracleParameter.sol100%100%100%100%
   PriceResponse.sol100%100%100%100%
packages/perennial-oracle/contracts/metaquants
   MetaQuantsFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/payoff
   Inverse.sol100%100%100%100%
   PowerHalf.sol100%100%100%100%
   PowerTwo.sol100%100%100%100%
packages/perennial-oracle/contracts/pyth
   PythFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/types
   OracleParameter.sol100%100%100%100%
packages/perennial-order/contracts
   Manager.sol100%100%100%100%
   Manager_Arbitrum.sol100%100%100%100%
   OrderVerifier.sol100%100%100%100%
packages/perennial-order/contracts/test
   TriggerOrderTester.sol100%100%100%100%
packages/perennial-order/contracts/types
   Action.sol100%100%100%100%
   CancelOrderAction.sol100%100%100%100%
   InterfaceFee.sol100%100%100%100%
   PlaceOrderAction.sol100%100%100%100%
   TriggerOrder.sol100%100%100%100%
packages/perennial-vault/contracts
   Vault.sol100%100%100%100%
   VaultFactory.sol100%100%100%100%
packages/perennial-vault/contracts/libs
   StrategyLib.sol100%100%100%100%
packages/perennial-vault/contracts/types
   Account.sol100%100%100%100%
   Checkpoint.sol100%100%100%100%
   Registration.sol100%100%100%100%
   VaultParameter.sol100%100%100%100%
packages/perennial-verifier/contracts
   Verifier.sol100%100%100%100%
packages/perennial-verifier/contracts/types
   AccessUpdate.sol100%100%100%100%
   AccessUpdateBatch.sol100%100%100%100%
   Intent.sol100%100%100%100%
   OperatorUpdate.sol100%100%100%100%
   SignerUpdate.sol100%100%100%100%

arjun-io
arjun-io reviewed Sep 9, 2024
View reviewed changes
.github/workflows/CI.yml Outdated
uses: romeovs/lcov-reporter-action@v0.3.1
with:
title: '[Extensions] Integration Test Coverage Report'
lcov-file: ./packages/perennial-extensions/coverage/lcov.info
title: '[Periphery] Test Coverage Report'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very tiny nit - can we add "Combined" before "Test" here for uniformity 😅

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Periphery] Unit Test Coverage Report

Coverage after merging prateek/combined-test-coverage into v2.3 will be
65.48%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-account/contracts
   Account.sol27.78%100%22.22%29.63%103, 108–109, 58, 64, 67–68, 71, 76–78, 81, 83–84, 89, 94–97
   AccountVerifier.sol100%100%100%100%
   Controller.sol66.98%100%77.27%64.29%100, 103–106, 108–109, 160, 207, 220, 225, 228–229, 231, 233–235, 239–241, 244, 252–256, 262–263, 98–99
   Controller_Arbitrum.sol0%100%0%0%24, 36
   Controller_Incentivized.sol0%100%0%0%105–108, 116, 118–120, 130–131, 133, 136, 146–147, 149, 152, 162–163, 165, 168, 178–179, 181, 184, 194–195, 197, 200, 204–205, 217–218, 221, 224, 46–47, 59–62, 70–71, 79–81, 89–90, 93–95, 98–99
packages/perennial-account/contracts/libs
   RebalanceLib.sol0%100%0%0%24, 27, 29, 31, 34
packages/perennial-account/contracts/test
   RebalanceConfigTester.sol100%100%100%100%
packages/perennial-account/contracts/types
   Action.sol100%100%100%100%
   DeployAccount.sol100%100%100%100%
   MarketTransfer.sol100%100%100%100%
   RebalanceConfig.sol100%100%100%100%
   RebalanceConfigChange.sol100%100%100%100%
   RelayedAccessUpdateBatch.sol100%100%100%100%
   RelayedGroupCancellation.sol100%100%100%100%
   RelayedNonceCancellation.sol100%100%100%100%
   RelayedOperatorUpdate.sol100%100%100%100%
   RelayedSignerUpdate.sol100%100%100%100%
   Withdrawal.sol100%100%100%100%
packages/perennial-extensions/contracts
   Coordinator.sol100%100%100%100%
   MultiInvoker.sol89.51%100%92.31%88.89%161, 163, 183, 186, 255, 360, 374, 392, 394, 396, 398, 88–89
   MultiInvoker_Arbitrum.sol0%100%0%0%37, 45
   MultiInvoker_Optimism.sol0%100%0%0%37, 45
packages/perennial-extensions/contracts/types
   TriggerOrder.sol96.43%100%100%95.83%55
packages/perennial-oracle/contracts
   Oracle.sol100%100%100%100%
   OracleFactory.sol93.55%100%88.89%95.45%62
packages/perennial-oracle/contracts/chainlink
   ChainlinkFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper
   KeeperFactory.sol87.36%100%78.57%89.04%164–165, 167–168, 211, 238, 82–83
   KeeperOracle.sol72%100%70.59%72.41%107, 158, 160–162, 164, 166–170, 173–174, 214, 70, 84
packages/perennial-oracle/contracts/keeper/libs
   DedupLib.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper/types
   KeeperOracleParameter.sol100%100%100%100%
   PriceResponse.sol100%100%100%100%
packages/perennial-oracle/contracts/metaquants
   MetaQuantsFactory.sol0%100%0%0%19, 30–31, 33–36, 38, 40, 42, 44–45, 54
packages/perennial-oracle/contracts/payoff
   Inverse.sol100%100%100%100%
   PowerHalf.sol100%100%100%100%
   PowerTwo.sol100%100%100%100%
packages/perennial-oracle/contracts/pyth
   PythFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/types
   OracleParameter.sol100%100%100%100%
packages/perennial-order/contracts
   Manager.sol90.54%100%94.44%89.29%190, 194, 196, 199, 218–219
   Manager_Arbitrum.sol100%100%100%100%
   OrderVerifier.sol100%100%100%100%
packages/perennial-order/contracts/test
   TriggerOrderTester.sol100%100%100%100%
packages/perennial-order/contracts/types
   Action.sol100%100%100%100%
   CancelOrderAction.sol100%100%100%100%
   InterfaceFee.sol100%100%100%100%
   PlaceOrderAction.sol100%100%100%100%
   TriggerOrder.sol100%100%100%100%
packages/perennial-vault/contracts
   Vault.sol0%100%0%0%104–105, 113–114, 123, 125, 132, 134, 140, 142–143, 146, 152–153, 155, 157–158, 165–167, 175–179, 186, 188, 190, 196, 198, 200–203, 206, 212–213, 219–220, 226–227, 229–230, 237–238, 240–242, 256–257, 259–262, 268–269, 271–273, 291–292, 295–305, 308, 311–313, 316–318, 320, 327, 337–338, 345, 348, 352–353, 359–360, 363, 366, 370, 383, 385, 393–398, 407, 413, 430, 444, 446–449, 451, 453–454, 457–459, 463–465, 468–470, 477–479, 486, 499–500, 503, 60, 62–65, 71, 78, 85, 92, 98
   VaultFactory.sol0%100%0%0%30–31, 36, 50, 54–56, 58, 65–66
packages/perennial-vault/contracts/libs
   StrategyLib.sol0%100%0%0%119–120, 122–123, 125–129, 135, 138–139, 153, 156, 160, 162, 165, 167, 179–183, 185–186, 188–189, 191, 197, 199, 202–205, 208, 93–98
packages/perennial-vault/contracts/types
   Account.sol100%100%100%100%
   Checkpoint.sol100%100%100%100%
   Registration.sol100%100%100%100%
   VaultParameter.sol100%100%100%100%
packages/perennial-verifier/contracts
   Verifier.sol100%100%100%100%
packages/perennial-verifier/contracts/types
   AccessUpdate.sol100%100%100%100%
   AccessUpdateBatch.sol100%100%100%100%
   Intent.sol100%100%100%100%
   OperatorUpdate.sol100%100%100%100%
   SignerUpdate.sol100%100%100%100%

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Core] Integration Test Coverage Report

Coverage after merging prateek/combined-test-coverage into v2.3 will be
86.89%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial/contracts
   Market.sol73.46%53%77.78%82.16%101, 111, 111–112, 117, 131, 131, 131, 131–132, 132, 132, 134, 136, 148, 172, 172, 172, 172–173, 177, 184, 187, 224, 251, 258, 258–260, 265, 272, 292, 297–299, 303–305, 309–311, 321, 329, 329–330, 332, 332, 332–333, 333, 333, 335, 337–338, 395, 402, 407, 413, 503, 591, 595, 602, 610, 627, 694–695, 697–698, 698, 698–699, 699, 699, 736, 784–786, 832–834, 867, 877, 883–884, 890
   MarketFactory.sol41.11%40%42.11%41.46%101–102, 109, 116–117, 117, 117, 119, 127–128, 135, 142–143, 143, 143, 145, 153–154, 161, 171–172, 172, 172, 174, 186–189, 195–196, 205, 207, 210–211, 47, 57, 84, 84, 84–85, 85, 92
packages/perennial/contracts/interfaces
   IMarket.sol100%100%100%100%
   IMarketFactory.sol100%100%100%100%
   IOracleProvider.sol100%100%100%100%
   IOracleProviderFactory.sol100%100%100%100%
packages/perennial/contracts/libs
   CheckpointLib.sol98.11%90%100%100%221
   InvariantLib.sol61.40%47.37%100%88.89%110, 116–117, 39–40, 42–43, 43, 43, 43, 52, 56, 56, 64, 69–70, 70, 78, 84–85, 85, 99
   MagicValueLib.sol63.16%50%100%62.50%61–64, 64, 64–65
   VersionLib.sol97.52%87.50%100%99.18%251, 428, 441–442
packages/perennial/contracts/types
   Checkpoint.sol74.07%50%100%100%55–61
   Global.sol79.69%53.57%100%100%140–152
   Guarantee.sol67.80%38.89%81.82%80%174–176, 199–202, 65, 65, 65, 67, 69, 69, 69, 71–72, 86
   Local.sol82.14%50%100%100%91–95
   MarketParameter.sol77.78%50%100%86.67%82–83, 85–86, 96–97
   OracleReceipt.sol100%100%100%100%
   OracleVersion.sol100%100%100%100%
   Order.sol77.38%55.17%93.55%87.34%100, 100, 100–101, 104, 104, 104, 104, 104, 104, 104–106, 110–111, 163, 183, 183, 241, 397–402, 473–475, 501–506, 98–99
   Position.sol78.07%57.69%87.10%82.46%111, 148, 203, 216, 300, 334–336, 352–354, 357, 357, 357, 357, 357–358, 360–361, 418, 439
   ProtocolParameter.sol74.19%50%100%100%66–68, 74–78
   RiskParameter.sol69.12%47.37%100%96.30%133, 139, 141, 147, 149, 151, 153, 155, 157, 160, 160, 160–161, 171–178
   Version.sol70.27%50%100%100%103–124

EdNoepel
EdNoepel approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the whitespace between sections for readability, and that Verifier tests are now run by CI.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Periphery] Integration Test Coverage Report

Coverage after merging prateek/combined-test-coverage into v2.3 will be
93.64%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-account/contracts
   Account.sol100%100%100%100%
   AccountVerifier.sol90.48%100%90.91%90%32
   Controller.sol89.62%100%90.91%89.29%141, 149, 275, 278, 282–284, 293, 310
   Controller_Arbitrum.sol100%100%100%100%
   Controller_Incentivized.sol100%100%100%100%
packages/perennial-account/contracts/libs
   RebalanceLib.sol100%100%100%100%
packages/perennial-account/contracts/test
   RebalanceConfigTester.sol0%100%0%0%10, 14
packages/perennial-account/contracts/types
   Action.sol100%100%100%100%
   DeployAccount.sol100%100%100%100%
   MarketTransfer.sol100%100%100%100%
   RebalanceConfig.sol20%100%33.33%14.29%34–35, 43–44, 46, 50
   RebalanceConfigChange.sol88.89%100%100%87.50%43
   RelayedAccessUpdateBatch.sol100%100%100%100%
   RelayedGroupCancellation.sol100%100%100%100%
   RelayedNonceCancellation.sol100%100%100%100%
   RelayedOperatorUpdate.sol100%100%100%100%
   RelayedSignerUpdate.sol100%100%100%100%
   Withdrawal.sol100%100%100%100%
packages/perennial-extensions/contracts
   Coordinator.sol0%100%0%0%18, 24–25, 31–32, 38–40, 47–48
   MultiInvoker.sol100%100%100%100%
   MultiInvoker_Arbitrum.sol0%100%0%0%37, 45
   MultiInvoker_Optimism.sol0%100%0%0%37, 45
packages/perennial-extensions/contracts/types
   TriggerOrder.sol96.43%100%100%95.83%55
packages/perennial-oracle/contracts
   Oracle.sol67.12%100%68.42%66.67%108–109, 118, 145, 168–169, 171, 173–174, 185, 187, 192–193, 57–58, 65, 91, 96
   OracleFactory.sol93.55%100%88.89%95.45%70
packages/perennial-oracle/contracts/chainlink
   ChainlinkFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper
   KeeperFactory.sol95.40%100%85.71%97.26%211, 76
   KeeperOracle.sol97.33%100%94.12%98.28%84
packages/perennial-oracle/contracts/keeper/libs
   DedupLib.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper/types
   KeeperOracleParameter.sol93.75%100%100%92.31%57
   PriceResponse.sol100%100%100%100%
packages/perennial-oracle/contracts/metaquants
   MetaQuantsFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/payoff
   Inverse.sol0%100%0%0%9
   PowerHalf.sol0%100%0%0%11
   PowerTwo.sol100%100%100%100%
packages/perennial-oracle/contracts/pyth
   PythFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/types
   OracleParameter.sol100%100%100%100%
packages/perennial-order/contracts
   Manager.sol100%100%100%100%
   Manager_Arbitrum.sol100%100%100%100%
   OrderVerifier.sol100%100%100%100%
packages/perennial-order/contracts/test
   TriggerOrderTester.sol0%100%0%0%17, 21, 25, 29
packages/perennial-order/contracts/types
   Action.sol100%100%100%100%
   CancelOrderAction.sol100%100%100%100%
   InterfaceFee.sol100%100%100%100%
   PlaceOrderAction.sol100%100%100%100%
   TriggerOrder.sol95.35%100%100%93.94%117, 47
packages/perennial-vault/contracts
   Vault.sol100%100%100%100%
   VaultFactory.sol100%100%100%100%
packages/perennial-vault/contracts/libs
   StrategyLib.sol100%100%100%100%
packages/perennial-vault/contracts/types
   Account.sol100%100%100%100%
   Checkpoint.sol100%100%100%100%
   Registration.sol100%100%100%100%
   VaultParameter.sol100%100%100%100%

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Periphery] Combined Test Coverage Report

Coverage after merging prateek/combined-test-coverage into v2.3 will be
99.32%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-account/contracts
   Account.sol100%100%100%100%
   AccountVerifier.sol100%100%100%100%
   Controller.sol100%100%100%100%
   Controller_Arbitrum.sol100%100%100%100%
   Controller_Incentivized.sol100%100%100%100%
packages/perennial-account/contracts/libs
   RebalanceLib.sol100%100%100%100%
packages/perennial-account/contracts/test
   RebalanceConfigTester.sol100%100%100%100%
packages/perennial-account/contracts/types
   Action.sol100%100%100%100%
   DeployAccount.sol100%100%100%100%
   MarketTransfer.sol100%100%100%100%
   RebalanceConfig.sol100%100%100%100%
   RebalanceConfigChange.sol100%100%100%100%
   RelayedAccessUpdateBatch.sol100%100%100%100%
   RelayedGroupCancellation.sol100%100%100%100%
   RelayedNonceCancellation.sol100%100%100%100%
   RelayedOperatorUpdate.sol100%100%100%100%
   RelayedSignerUpdate.sol100%100%100%100%
   Withdrawal.sol100%100%100%100%
packages/perennial-extensions/contracts
   Coordinator.sol100%100%100%100%
   MultiInvoker.sol100%100%100%100%
   MultiInvoker_Arbitrum.sol0%100%0%0%37, 45
   MultiInvoker_Optimism.sol0%100%0%0%37, 45
packages/perennial-extensions/contracts/types
   TriggerOrder.sol96.43%100%100%95.83%55
packages/perennial-oracle/contracts
   Oracle.sol100%100%100%100%
   OracleFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/chainlink
   ChainlinkFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper
   KeeperFactory.sol97.70%100%92.86%98.63%211
   KeeperOracle.sol97.33%100%94.12%98.28%84
packages/perennial-oracle/contracts/keeper/libs
   DedupLib.sol100%100%100%100%
packages/perennial-oracle/contracts/keeper/types
   KeeperOracleParameter.sol100%100%100%100%
   PriceResponse.sol100%100%100%100%
packages/perennial-oracle/contracts/metaquants
   MetaQuantsFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/payoff
   Inverse.sol100%100%100%100%
   PowerHalf.sol100%100%100%100%
   PowerTwo.sol100%100%100%100%
packages/perennial-oracle/contracts/pyth
   PythFactory.sol100%100%100%100%
packages/perennial-oracle/contracts/types
   OracleParameter.sol100%100%100%100%
packages/perennial-order/contracts
   Manager.sol100%100%100%100%
   Manager_Arbitrum.sol100%100%100%100%
   OrderVerifier.sol100%100%100%100%
packages/perennial-order/contracts/test
   TriggerOrderTester.sol100%100%100%100%
packages/perennial-order/contracts/types
   Action.sol100%100%100%100%
   CancelOrderAction.sol100%100%100%100%
   InterfaceFee.sol100%100%100%100%
   PlaceOrderAction.sol100%100%100%100%
   TriggerOrder.sol100%100%100%100%
packages/perennial-vault/contracts
   Vault.sol100%100%100%100%
   VaultFactory.sol100%100%100%100%
packages/perennial-vault/contracts/libs
   StrategyLib.sol100%100%100%100%
packages/perennial-vault/contracts/types
   Account.sol100%100%100%100%
   Checkpoint.sol100%100%100%100%
   Registration.sol100%100%100%100%
   VaultParameter.sol100%100%100%100%
packages/perennial-verifier/contracts
   Verifier.sol100%100%100%100%
packages/perennial-verifier/contracts/types
   AccessUpdate.sol100%100%100%100%
   AccessUpdateBatch.sol100%100%100%100%
   Intent.sol100%100%100%100%
   OperatorUpdate.sol100%100%100%100%
   SignerUpdate.sol100%100%100%100%

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Core] Unit Test Coverage Report

Coverage after merging prateek/combined-test-coverage into v2.3 will be
97.03%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial/contracts
   Market.sol90.50%83%86.67%94.84%111–112, 117, 117, 131, 172, 172, 224, 329, 329–330, 332, 332, 332–333, 333, 333, 335, 337–338, 395, 402, 407, 413, 694–695, 698–699
   MarketFactory.sol95.56%93.33%94.74%97.56%57, 84–85
packages/perennial/contracts/interfaces
   IMarket.sol100%100%100%100%
   IMarketFactory.sol100%100%100%100%
   IOracleProvider.sol100%100%100%100%
   IOracleProviderFactory.sol100%100%100%100%
packages/perennial/contracts/libs
   CheckpointLib.sol100%100%100%100%
   InvariantLib.sol100%100%100%100%
   MagicValueLib.sol100%100%100%100%
   VersionLib.sol100%100%100%100%
packages/perennial/contracts/types
   Checkpoint.sol100%100%100%100%
   Global.sol96.88%92.86%100%100%146, 148
   Guarantee.sol96.61%100%90.91%96.67%86
   Local.sol100%100%100%100%
   MarketParameter.sol100%100%100%100%
   OracleReceipt.sol100%100%100%100%
   OracleVersion.sol100%100%100%100%
   Order.sol97.02%94.83%96.77%98.73%100, 104, 241, 400
   Position.sol87.72%84.62%93.55%85.96%216, 352–354, 357, 357, 357, 357, 357–358, 360–361
   ProtocolParameter.sol100%100%100%100%
   RiskParameter.sol97.06%94.74%100%100%139, 174
   Version.sol100%100%100%100%

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Core] Combined Test Coverage Report

Coverage after merging prateek/combined-test-coverage into v2.3 will be
97.03%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial/contracts
   Market.sol93.33%100%85.71%94.84%112, 330, 332–333, 335, 337–338, 395, 402, 407, 413
   MarketFactory.sol96.67%100%94.74%97.56%57
packages/perennial/contracts/libs
   CheckpointLib.sol100%100%100%100%
   InvariantLib.sol100%100%100%100%
   MagicValueLib.sol100%100%100%100%
   VersionLib.sol100%100%100%100%
packages/perennial/contracts/types
   Checkpoint.sol100%100%100%100%
   Global.sol100%100%100%100%
   Guarantee.sol94.87%100%88.89%96.67%86
   Local.sol100%100%100%100%
   MarketParameter.sol100%100%100%100%
   Order.sol98.13%100%96.43%98.73%241
   Position.sol89.02%100%96%85.96%216, 352–354, 357–358, 360–361
   ProtocolParameter.sol100%100%100%100%
   RiskParameter.sol100%100%100%100%
   Version.sol100%100%100%100%

@prateekdefi prateekdefi merged commit 031d1d4 into v2.3 Sep 9, 2024
19 checks passed
@prateekdefi prateekdefi deleted the prateek/combined-test-coverage branch September 9, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdNoepel EdNoepel EdNoepel approved these changes

@arjun-io arjun-io arjun-io approved these changes

@kbrizzle kbrizzle Awaiting requested review from kbrizzle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prateekdefi @kbrizzle @arjun-io @EdNoepel