Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ownable reinitialization check #101

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

kbrizzle
Copy link
Contributor

No description provided.

@kbrizzle kbrizzle requested a review from arjun-io August 23, 2024 08:20
Copy link

Unit Test Coverage Report

Coverage after merging britz-reinitialize-check into v2.3 will be
98.79%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/access
   ProxyOwner.sol100%100%100%100%
contracts/accumulator/types
   Accumulator6.sol100%100%100%100%
   UAccumulator6.sol100%100%100%100%
contracts/adiabatic
   AdiabaticMath6.sol100%100%100%100%
contracts/adiabatic/types
   LinearAdiabatic6.sol100%100%100%100%
   NoopAdiabatic6.sol100%100%100%100%
contracts/attribute
   Factory.sol96.30%75%100%100%25
   Initializable.sol100%100%100%100%
   Instance.sol75%62.50%100%71.43%19, 31–32, 37–38
   Ownable.sol93.75%90%88.89%100%27
   Pausable.sol96.88%91.67%100%100%29
   ReentrancyGuard.sol90.91%75%100%100%40
contracts/attribute/CrossChainOwnable
   CrossChainOwnable_Arbitrum.sol100%100%100%100%
   CrossChainOwnable_Optimism.sol100%100%100%100%
   CrossChainOwnable.sol90%75%100%100%25
contracts/attribute/CrossChainOwner
   CrossChainOwner_Arbitrum.sol100%100%100%100%
   CrossChainOwner_Optimism.sol100%100%100%100%
   CrossChainOwner.sol91.67%83.33%100%100%14
contracts/attribute/Kept
   Kept_Arbitrum.sol100%100%100%100%
   Kept_Optimism.sol100%100%100%100%
   Kept.sol92.59%50%90%100%26
contracts/attribute/interfaces
   IFactory.sol100%100%100%100%
   IInitializable.sol100%100%100%100%
   IInstance.sol100%100%100%100%
   IKept.sol100%100%100%100%
   IOwnable.sol100%100%100%100%
   IPausable.sol100%100%100%100%
   IReentrancyGuard.sol100%100%100%100%
contracts/gas
   GasOracle_Arbitrum.sol0%100%0%100%
   GasOracle_Optimism.sol0%100%0%0%36
   GasOracle.sol100%100%100%100%
contracts/gas/interfaces
   IGasOracle.sol100%100%100%100%
contracts/mocks
   GasOracleRunner.sol100%100%100%100%
   MockAccumulator6.sol100%100%100%100%
   MockAdiabaticMath6.sol100%100%100%100%
   MockCrossChainOwnable_Arbitrum.sol50%50%50%50%11–12, 7
   MockCrossChainOwnable_Optimism.sol50%50%50%50%11–12, 7
   MockCurveMath18.sol100%100%100%100%
   MockCurveMath6.sol100%100%100%100%
   MockERC20.sol100%100%100%100%
   MockFactory.sol83.33%62.50%100%100%10, 14, 18
   MockFixed18.sol100%100%100%100%
   MockFixed6.sol100%100%100%100%
   MockInitializable.sol96.15%90%100%100%20, 59
   MockInstance.sol68.75%62.50%60%100%13, 27, 30
   MockJumpRateUtilizationCurve18.sol100%100%100%100%
   MockJumpRateUtilizationCurve6.sol100%100%100%100%
   MockKept_Arbitrum.sol88.89%50%100%100%16, 36
   MockKept_Optimism.sol88.89%50%100%100%16, 36
   MockKept.sol88.89%50%100%100%16, 28
   MockLinearAdiabatic6.sol100%100%100%100%
   MockNoopAdiabatic6.sol100%100%100%100%
   MockNumberMath.sol100%100%100%100%
   MockOwnable.sol80%50%100%100%13, 9
   MockPAccumulator6.sol100%100%100%100%
   MockPausable.sol90%75%100%100%9
   MockPController6.sol100%100%100%100%
   MockReentrancyGuard.sol86.67%75%100%100%11, 21
   MockStorage.sol100%100%100%100%
   MockToken18.sol100%100%100%100%
   MockToken6.sol100%100%100%100%
   MockTokenOrEther18.sol100%100%100%100%
   MockUAccumulator6.sol100%100%100%100%
   MockUFixed18.sol100%100%100%100%
   MockUFixed6.sol100%100%100%100%
   MockUJumpRateUtilizationCurve18.sol100%100%100%100%
   MockUJumpRateUtilizationCurve6.sol100%100%100%100%
contracts/number
   NumberMath.sol100%100%100%100%
contracts/number/types
   Fixed18.sol100%100%100%100%
   Fixed6.sol100%100%100%100%
   UFixed18.sol100%100%100%100%
   UFixed6.sol100%100%100%100%
contracts/pid/types
   PAccumulator6.sol100%100%100%100%
   PController6.sol91.67%83.33%100%100%49
contracts/storage
   Storage.sol100%100%100%100%
contracts/token/types
   Token18.sol100%100%100%100%
   Token6.sol100%100%100%100%
   TokenOrEther18.sol100%100%100%100%
contracts/utilization
   CurveMath18.sol100%100%100%100%
   CurveMath6.sol100%100%100%100%
contracts/utilization/types
   JumpRateUtilizationCurve18.sol83.33%100%50%83.33%56
   JumpRateUtilizationCurve6.sol83.33%100%50%83.33%55
   UJumpRateUtilizationCurve18.sol83.33%100%50%83.33%56
   UJumpRateUtilizationCurve6.sol83.33%100%50%83.33%55
contracts/verifier
   VerifierBase.sol100%100%100%100%
contracts/verifier/interfaces
   IVerifierBase.sol100%100%100%100%
contracts/verifier/test
   VerifierBaseTester.sol100%100%100%100%
contracts/verifier/types
   Common.sol100%100%100%100%
   GroupCancellation.sol100%100%100%100%

@kbrizzle kbrizzle merged commit e258735 into v2.3 Aug 23, 2024
2 checks passed
@kbrizzle kbrizzle deleted the britz-reinitialize-check branch August 23, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants