Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deprecation comment to go.mod #38

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Aug 7, 2024

Adding a deprecation comment to go.mod means that we get a deprecation announcement on pkg.go.dev (for example, see https://pkg.go.dev/github.com/equinix-labs/metal-go) and users will see a warning in the console output when they upgrade fabric-go.

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ctreatma !

@thogarty thogarty merged commit 79fa876 into main Aug 7, 2024
2 checks passed
@thogarty thogarty deleted the deprecation-notice branch August 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants