Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC header authentication not working and untested #231

Closed
tobert opened this issue Jun 28, 2023 · 3 comments
Closed

gRPC header authentication not working and untested #231

tobert opened this issue Jun 28, 2023 · 3 comments

Comments

@tobert
Copy link
Collaborator

tobert commented Jun 28, 2023

While working on #226, @mterhar ran into issues with gRPC headers. This area of critical code is not currently tested at all. I'm going to merge #227 since it's accomplished its goals, and open a new PR for this issue.

Task 1: write a bunch of tests for gRPC headers
Task 2: fix whatever bugs show up
@tobert
Copy link
Collaborator Author

tobert commented Jun 28, 2023

Started #232

@tobert
Copy link
Collaborator Author

tobert commented Jun 28, 2023

Figured it out. I was putting the headers in grpc options. The OTel collector does it via context and the metadata package. Oops. Writing tests now, will push up to PR soon.

@tobert
Copy link
Collaborator Author

tobert commented Jun 28, 2023

Merged #232.

@tobert tobert closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobert