fill in some testing gaps, fix grpc headers #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 27, 2023 07:10
Not complete, but works. Set up as a table test, with just one simple test for now.
Also expanded test to compare error lists.
There was an egregious testing gap. Mea culpa. Adds tests for headers through grpc and http. To do that, header support had to be added to the servers, so I did that. That provided the data needed to augment the test harness to check headers. Added that. Added functional tests that exercise the headers end-to-end. Noticed grpc.WaitForReady() while I was perusing otel collector and grpc docs, added a TODO to look into it later. Might be useful for otel-cli status.
also added * support to checkHeaders
tobert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #227 a few gaps in testing were exposed, especially for gRPC and HTTP headers.
This PR adds functional tests for gRPC and HTTP header passing. Along the way I found the bug
in gRPC headers. When I wrote the gRPC client I assumed headers would be passed in with grpcOpts.
This was very wrong. I looked at the OTel collector, and it is passing them via grpc
metadata. So Ifixed that.
Also added a test for the new ErrorList functionality. Just a single test for now but it's set up to add more.