New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference correct span parameter name #102

Merged

tobert merged 1 commit into equinix-labs:main from ericksoen:main

Jan 24, 2022

Contributor

ericksoen commented Jan 20, 2022

The current behavior when using the provided example returns the following error message: Error: unknown flag: --system

Update the example docs to use the correct parameter name (see documentation for span parameters):

func addSpanParams(cmd *cobra.Command) {
	// --name / -s
	cmd.Flags().StringVarP(&config.SpanName, "name", "s", defaults.SpanName, "set the name of the span")
	// --service / -n
	cmd.Flags().StringVarP(&config.ServiceName, "service", "n", defaults.ServiceName, "set the name of the application sent on the traces")
...
}


          reference correct span parameter name

a8f6425

tobert approved these changes

View reviewed changes

Collaborator

tobert left a comment

Thank you!

tobert merged commit 86c6b24 into equinix-labs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet