feat: add span status code/description cli and env var #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayworth
approved these changes
Aug 9, 2022
| case "error": | ||
| return codes.Error | ||
| default: | ||
| return codes.Unset |
There was a problem hiding this comment.
It would be nice to warn here I suppose, but it's not blocking or anything.
|
@tobert Any plans to merge it in? |
|
Yeah. Apologies, I've been busy. I'm away from my dev machine right now. I
will make some time in the next day or two to read & merge. And release, if
that helps.
…-Amy
On Sat, Oct 1, 2022 at 9:29 AM Sergii Puliaiev ***@***.***> wrote:
@tobert <https://github.com/tobert> Any plans to merge it in?
—
Reply to this email directly, view it on GitHub
<#111 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWSHXAXMRGIMUOSYVMHATWBBRHBANCNFSM55ZGMTNQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
tobert
approved these changes
Oct 5, 2022
|
@tobert no worries, thank you for circling back to this and also for this repo in general, good stuff! |
|
@tobert Any plans to release the tool with the status flag? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #27 , which was quite out of date so i'm closing it.
This pr adds
--status-code, OTEL_CLI_STATUS_CODE, status-codeand--status-description, OTEL_CLI_STATUS_DESCRIPTION, status-descriptionCli Argument, Env var, and config key, respectively, for setting a span status's code and description.An important note is that description will only be set if the span status code is an
error, which conforms to the specificationhttps://github.com/open-telemetry/opentelemetry-specification/blob/480a19d702470563d32a870932be5ddae798079c/specification/trace/api.md#set-status
There's a few rough edges, in that this doesn't get respected for clievents ( didnt seem necessary) and execCmd stuffs (i figure that was handled by the
--failoption). Also, I didn't include a shorthand syntax for either CLI arg, since they have to be single letter, andcwas taken already, and it just kinda felt like it'd become a bikeshed for very little value so i dropped it.But i figure this is a good starting point, and since the older PR had fallen out of date, i wanted to at least implement the feedback that was added on there. I have pretty limited bandwidth but happy to fix anything up if needed here