Make configurable skipping pid check in span background command #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobert
requested changes
Feb 21, 2023
otelcli/config.go
Outdated
| BackgroundParentPollMs int `json:"background_parent_poll_ms" env:""` | ||
| BackgroundSockdir string `json:"background_socket_directory" env:""` | ||
| BackgroundWait bool `json:"background_wait" env:""` | ||
| BackgroundSkipParentPidCheck bool `json:"background_skip_pid_check"` |
There was a problem hiding this comment.
Ideally the json will match the variable name here, to be consistent. Usually I prefer to shorten the variable name and let the json key be as long as it takes to be clear. Please switch it to background_skip_parent_pid_check and I'll be happy to merge.
There was a problem hiding this comment.
Sure, so I switched it to background_skip_parent_pid_check
Closed
lwronski
force-pushed
the
skip-pid-check
branch
from
56a4bc5 to
80fdb13
Compare
tobert
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160.