refactor Config out of otlpclient #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 15, 2023 06:59
First step in splitting out config is adding getter methods to Config and moving code to use an interface instead.
Fills in OTLPConfig interface with the needed methods to break dependence on Config so it can move out.
protobuf span is now clear of Config usage. This can move with Config and can stay with it since it's all about translating otel-cli config to a span and is useless otherwise.
Nothing was using the retry counter and Diag can't work in otlpclient anymore so out it goes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just does the first round of refactoring so that Config can move out of otlpclient. The OTLP clients themselves are now free of the Config object and instead expect a config that complies to an interface called OTLPConfig. In theory, this makes it easier for someone else to use the otlpclient. That's not really the goal but implies the right design & code boundaries.
This mostly moves code around without changing functionality. I deprecated --with-blocking since it's never really seemed useful, and that's one less config thing to pass around.