return a clear error when http/protobuf server returns json #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 12, 2023 15:11
In #262 it was reported that a vendor's OTLP server responded to an http/protobuf trace upload with a JSON response. I checked with a vendor contact and they confirmed this is not supposed to happen and means their server is out of spec. I might be convinced to just accept the JSON as long as it's a valid ExportTraceServiceResponse but for now, add an error that informs users clearly that it's the server's fault.
Tests were failing on the new check, which is good, because they were under-specified. They now set a Content-Type header to pass what should pass. Added 2 tests for the new server compliance checks too.
|
@mterhar can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of what's going on in #262. I had a chat with a contact at the OTLP vendor in the report and they confirmed their server is out of spec. This will at least make it clear that the server is being naughty instead of otel-cli.
I can be convinced to make either work, it's not a huge lift, and mostly I prefer users have a good time v.s. reporting naughty servers. I'll wait to merge this a day or two so folks can comment.