add tests for attrs at end of bg trace #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. It's failing on my machine, I'll figure that out then merge. |
|
Oh neat, it exposes another bug where using the same sockdir in 2 invocations, the second one fails. I suspect I need to cleanup the socket better. |
After some tests were added, they failed on my machine. Looking into it, it turned out that the sockfile from previous span background operations lingered and caused subsequent tests to fail. I'm not sure why it didn't fail in CI but it doesn't hurt to unlink the file just to be sure. I skipped error checking on it for now, so that it doesn't have to be careful about whether the file exists or not.
|
How odd! I ran the tests a few times to make sure I was getting it right and didn't notice that.
Thanks! This is such a neat tool!
…On Thu, 21 Sep 2023, at 00:23, Amy Tobey wrote:
Oh neat, it exposes another bug where using the same sockdir in 2 invocations, the second one fails. I suspect I need to cleanup the socket better.
—
Reply to this email directly, view it on GitHub <#269 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2NIGUWLHAGNOAAQUJN6CDX3L36JANCNFSM6AAAAAA43JQPV4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple of tests as per #255 (comment)
Let me know if there is another case which should be covered or if these should be more thorough.