add exec --command-timeout #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 22, 2023 13:44
global exec help was outdated from before we moved away from 'sh -c' --command-timeout still had copypasta from --timeout that was wrong
This commit will fail because the span deadline fails because it's based on otel-cli's start time. Will fix in next commit.
Removes config.StartupTime, which used to be used to compute all the deadlines. With this change, that variable goes away and sites use time.Now() instead. Also, the last remaining automatic deadline is in the retry() function. This should get removed eventually but a stub is in place to keep things working for now.
I switched these in some recent PR and that was the wrong decision since test methods aren't allowed in goroutines.
|
Thank you for this! 😄 Sorry, only now got around trying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
otel-cli exec --comand-timeout 1s sleep 2functionality so that the command timeout is separate from the global/OTel timeout.Addresses #55
Code seems to work now. Needs tests before merging.
Also includes a
go mod tidythat was necessary after renovate PRs that seem to always leave some goop.