chore(ci): run tests against PRs #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've misjudged the effect of the current config. PRs are being run against source and fork branches today without the proposed change. #353 |
|
It looks like branch protection rules are triggering CI today. This PR will make that configuration more explicit which should help forks and orgs hosting this project without explicit branch protection policies. |
nshalman
approved these changes
Jul 26, 2024
tobert
reviewed
Aug 2, 2024
| # otel-cli's main test needs the binary built ahead of time | ||
| # also this validates it can acutally build before we get there | ||
| - name: Build | ||
| # build with -s -w to reduce binary size and verify that build in test | ||
| run: go build -v -ldflags="-s -w -X main.version=test -X main.commit=${{ github.sha }}" | ||
| - name: Test | ||
| run: go test -v ./... | ||
| run: go test -v -cover -parallel 4 ./... |
There was a problem hiding this comment.
It probably won't hurt anything but the test suite won't really parallelize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly run tests against PRs.
Keep the Go test environment in sync with go.mod.
Changes were pulled in comparison to https://github.com/equinix/metal-cli/blob/main/.github/workflows/test.yml