split server into package #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 24, 2021 09:02
everything is broken rn :) Signed-off-by: Amy Tobey <atobey@equinix.com>
Not the cleanest API but this isn't meant to be used for Serious Stuff. Signed-off-by: Amy Tobey <atobey@equinix.com>
it messes up command line completion but this is the right name, sigh Signed-off-by: Amy Tobey <atobey@equinix.com>
Signed-off-by: Amy Tobey <atobey@equinix.com>
Signed-off-by: Amy Tobey <atobey@equinix.com>
Signed-off-by: Amy Tobey <atobey@equinix.com>
Signed-off-by: Amy Tobey <atobey@equinix.com>
With some minor doc updates. Signed-off-by: Amy Tobey <atobey@equinix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes most of the gRPC server code in cmd/server.go and moves it into /otlpserver. Everything else should still work the same, only now this server is available as an importable package which is handy for testing other otel things.