Added basic subcommand completion #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just added the sample shell completion logic, straight copy-paste. Will need to discuss customizing for required flags on all subcommands?
tobert
approved these changes
Sep 1, 2021
| # To load completions for every new session, run: | ||
| PS> otel-cli completion powershell > otel-cli.ps1 | ||
| # and source this file from your PowerShell profile. | ||
| `, |
There was a problem hiding this comment.
Typically I would put this huge string at the bottom of the struct but it's fine.
I love how thorough the instructions are!
|
"Will need to discuss customizing for required flags on all subcommands?" @emattiza if I understand you, yeah that's a good idea. I'll merge this and write up an issue for that. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #57. Just added the sample shell completion logic, straight copy-paste from cobra/shell_completions.md. Will need to discuss customizing for required flags on all or some subcommands? Whats the mix of env-vars and flags required per command, or omit and discover via help?
Here's some sample pics at root:
Under server:
Under span:
Under completion (listing valid completion targets):