add status subcommand #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2021 16:11
Signed-off-by: Amy Tobey <atobey@equinix.com>
partially based on https://github.com/equinix-labs/otel-init-go/blob/main/cmd/test-otel-init-go/main.go Signed-off-by: Amy Tobey <atobey@equinix.com>
|
@ahayworth @emattiza does this look ok to merge as a first pass? Scroll down to the bottom of the diff. Most of it is just moving config into the Config struct instead of a bajillion globals. The meat of status is at the end (and yeah they could be 2 PRs but this won't be big and professional like gnu). |
|
Hmm I might actually split this so I can do the viper/cobra refactor while we iterate on status elsewhere. I think I can do this without too much disruption via some rebasing tricks. |
ahayworth
previously approved these changes
Sep 9, 2021
Signed-off-by: Amy Tobey <atobey@equinix.com>
remove --canary mention since it's not a thing yet Signed-off-by: Amy Tobey <atobey@equinix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements first pass of #63
I realized something is up with otel-cli's parsing of OTEL_EXPORTER_OTLP_ENDPOINT and needed status to troubleshoot it. It's still not fixed but this should be ok to merge. I'll hold off releasing until I figure out the envvar thing. It might lead to doing bits of #65