Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added readme.md in root and cpem-add-on example #23

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

dcallao
Copy link
Contributor

@dcallao dcallao commented Sep 6, 2023

This PR contains the following changes:

  • Adds README.md into root module
  • Adds README.md into cpem-add-on example

main.tf Show resolved Hide resolved
@dcallao
Copy link
Contributor Author

dcallao commented Sep 6, 2023

@ctreatma I have submitted this PR to fix the docs in the repo. The integration tests CI still fails. Take a look when you have a moment. Thanks!

@ctreatma
Copy link
Collaborator

ctreatma commented Sep 6, 2023

Yes, the integration test job has not been fixed yet: #21

Copy link
Collaborator

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with the file path fix from this PR and a BGP-enabled project, the integration workflow still doesn't pass. Going ahead and merging this since it's mostly a docs change anyway.

@ctreatma ctreatma merged commit 9bb2d58 into main Sep 7, 2023
1 of 2 checks passed
@ctreatma ctreatma deleted the add_readme branch September 7, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants