CRH Cloud event update #14
Open
+117
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-equinix
requested review from
ryli17 and
thogarty
and removed request for
ryli17
ryli17
requested changes
Dec 18, 2024
thogarty
requested changes
Jan 8, 2025
| "domain": "Equinix Resource Manager ChangeEvent", | ||
| "$schema": "http://json-schema.org/draft-04/schema#", | ||
| "$ref": "#/definitions/Data", | ||
| "definitions": { | ||
| "SpecVersion": { |
There was a problem hiding this comment.
Definitions aren't properly defined. You're creating many different model types in your definition that should just be properties of a single model definition. See
for reference.
thogarty
requested changes
Jan 8, 2025
| @@ -31,17 +81,5 @@ | |||
| "title": "Resource", | |||
| "description": "Schema of the resource that fired the event" | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
Leave these definitions at the end of the file, and all must be included. Remove the attribute from the beginning of the file on line https://github.com/equinix/equinix-cloudevents/pull/14/files#diff-b53020bebf4fb260b25992533608a4bab6f840f83b568f62804d114cdb147f72R7-R8
…Updates - Wed Jan 8 00:42:54 UTC 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
previewandreleasedlists for Events/Metrics/Alerts are correctreleasedare properly tested and ready for productionCRH Observability event schema