Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require token for completions subcommand #74

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Do not require token for completions subcommand #74

merged 1 commit into from
Aug 12, 2020

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Aug 12, 2020

Removes the requirement of having a packet api token configured
to run the completions subcommand

@detiber
Do not require token for completions subcommand
7a9ae27 
Removes the requirement of having a packet api token configured
to run the completions subcommand
displague
displague approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @detiber!

I ran this without a token to see that packet completion bash did not error and that packet devices get returned an appropriate error.

Unrelated to your PR, I'll note that

@displague displague merged commit dd3619b into equinix:master Aug 12, 2020
@displague displague mentioned this pull request Aug 19, 2020
Closed
@displague displague mentioned this pull request Jan 4, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@detiber @displague