This repository has been archived by the owner on Aug 23, 2024. It is now read-only.
Simplify private_subnets variable with appropriate defaults #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
approved these changes
May 9, 2023
displague
changed the title
displague
reviewed
May 18, 2023
empovit
commented
May 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.3.0 of Terraform has concluded the
module_variable_optional_attrsexperiment. This PR removes the experiment and upgrades the optional variables to use the updated syntax. It also makesvsphere_service_typeexplicitly optional instead of requiring anullwhen a service type cannot be specified.Important: The updated syntax requires Terraform 1.3.0 or later, which is likely to be the case on any modern system anyway. Users with older versions of Terraform will have to upgrade.