-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VRF Support #129
Add VRF Support #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 58.77% 57.20% -1.58%
==========================================
Files 65 67 +2
Lines 10867 11190 +323
==========================================
+ Hits 6387 6401 +14
- Misses 4242 4574 +332
+ Partials 238 215 -23
Continue to review full report at Codecov.
|
a1c97c0
to
32e88fc
Compare
I'm seeing some failed tests related to the I've reached out for more information about why this has started failing (the |
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
…precreated_ip_block Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
…VRF+VC tests Signed-off-by: Marques Johansson <mjohansson@equinix.com>
…H Actions Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
…ting vrf aware Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
One final change needed is to update packngo in go.mod to the latest tagged release following equinixmetal-archive/packngo#326. This branch currently refers to a git commit in the packngo PR. Merging this PR without an update to a tagged packngo will be safe unless the packngo PR is rebased. |
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
I filed an issue related to some of the failed CI/CD tests: #130 I attempted to correct some of this in this PR but there are more than I missed. I believe we should address these in a separate PR (accepting the changes that are already committed in this PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after revision in a screen sharing session. Awesome job 👌🏻👌🏻
Related to: equinix/terraform-provider-metal#220
To run this branch locally:
Update your
required_versions
(usually in main.tf or versions.tf):Example resources:
Find other examples in the
*acc_test.go
files.