Fabric v4 - Port data schema implementation and Terraform Script - Create Connection example #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port data schema implementation
displague
changed the title
43 tasks
displague
requested changes
Jul 27, 2022
There was a problem hiding this comment.
We are missing the commit that introduces the provider resource and datasource definition. equinix/provider.go
We'll also want func resourceFabricPort() *schema.Resource { return &schema.Resource{ ...
I think we can leave Create/Update/Delete unimplemented if we want to merge early and iterate from there.
|
|
||
| func readFabricPortTether() map[string]*schema.Schema { | ||
| return map[string]*schema.Schema{ | ||
| "cross_onnect_id": { |
There was a problem hiding this comment.
Suggested change
| "cross_onnect_id": { | |
| "cross_connect_id": { |
I assume this is a typo
| func dataSourceFabricPort() *schema.Resource { | ||
| return &schema.Resource{ | ||
| ReadContext: dataSourceFabricPortRead, | ||
| Schema: readFabricPortResourceSchema(), |
| }, | ||
| "uuid": { | ||
| Type: schema.TypeString, | ||
| Computed: true, |
There was a problem hiding this comment.
Suggested change
| Computed: true, | |
| Required: true, |
|
I shared files offline with developer. we will also create a separate repo for our internal collaboration, after we finish all the development, testing, and review we will create a single PR into master or fabric-v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port data schema implementation and Terraform Script - Create Connection example.
Part of #112