Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fabric resources behavior #263

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Fix fabric resources behavior #263

merged 6 commits into from
Nov 10, 2022

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Nov 9, 2022 •
edited
Loading

  • simplifiedServiceProfileToTerra were using createLocationRes to generate new set
  • Added waitUntilConnectionIsProvisioned and waitUntilConnectionDeprovisioned, this caused errors when trying to delete a newly created connection that is not yet provisioned
  • Some attributes were being returned while Read, but they weren't marked as Computed, this caused differences in the schema when re-apply with no changes
  • Added Set: to a_side, and z_side schemas and others. It seems that mapping TypeSet with nested TypeSet structures and with computed attributes doesn't work properly causing differences in the schema when re-apply with no changes
  • Many changes in the behavior of the schema, since many fields marked as optional are not sent to the API
  • Fixed examples output and remove unnecessary time_sleep
  • Fixed linter warnings

syedluri
syedluri reviewed Nov 9, 2022
View reviewed changes
equinix/fabric_service_profile_schema.go Outdated Show resolved Hide resolved
equinix/resource_fabric_connection.go Show resolved Hide resolved
equinix/resource_fabric_connection.go Outdated Show resolved Hide resolved
equinix/resource_fabric_service_profile.go Outdated Show resolved Hide resolved
examples/connectivity/v4/azure/main.tf Show resolved Hide resolved
@ocobles ocobles merged commit 10a7c5d into fabric-v4 Nov 10, 2022
@ocobles ocobles deleted the fix-fabric-resources-behavior branch November 10, 2022 19:26
@displague displague mentioned this pull request Aug 22, 2023
Closed
thogarty pushed a commit that referenced this pull request Sep 5, 2023
@ocobles
Merge pull request #263 from equinix/fix-fabric-resources-behavior
369cef0 
Fix fabric resources behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedluri syedluri syedluri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocobles @syedluri