Deprecate facility/facilities #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 53.80% 51.07% -2.73%
==========================================
Files 90 90
Lines 17913 17926 +13
==========================================
- Hits 9638 9156 -482
- Misses 8077 8605 +528
+ Partials 198 165 -33
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ocobles
previously requested changes
Apr 10, 2023
There was a problem hiding this comment.
- We need to add a deprecation note in the https://github.com/equinix/terraform-provider-equinix/blob/master/docs/data-sources/equinix_metal_facility.md documentation:
# equinix_metal_facility (Data Source)
> **DEPRECATED** Use metro instead...
- I found some example using facility/facilities in
- https://github.com/equinix/terraform-provider-equinix/blob/master/docs/resources/equinix_metal_bgp_session.md
- https://github.com/equinix/terraform-provider-equinix/blob/master/docs/resources/equinix_metal_vlan.md
- https://github.com/equinix/terraform-provider-equinix/blob/master/docs/resources/equinix_metal_reserved_ip_block.md
ctreatma
force-pushed
the
deprecate-facility
branch
2 times, most recently
from
07c4fdd to
9df8220
Compare
ctreatma
force-pushed
the
deprecate-facility
branch
from
9df8220 to
fe3c7d8
Compare
This marks all `facility` and `facilities` properties as deprecated, and deprecates `data_source_equinix_metal_facility`. Deprecation messages link to the facility-to-metro [migration guide]. That migration guide was updated in a separate PR to include a link to the [facilities deprecation announcement]. [migration guide]: https://registry.terraform.io/providers/equinix/equinix/latest/docs/guides/migration_guide_facilities_to_metros_devices [facilities deprecation announcement]: https://feedback.equinixmetal.com/changelog/bye-facilities-hello-again-metros.
ctreatma
force-pushed
the
deprecate-facility
branch
from
fe3c7d8 to
af87315
Compare
|
Acceptance tests are broken until https://github.com/packethost/api/pull/8526 is merged & deployed. We could skip tests that create organizations, but IMO it's not worth it to do that since there is already a fix in flight. I ran tests locally to validate that none of the |
thogarty
pushed a commit
that referenced
this pull request
Sep 5, 2023
Deprecate facility/facilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks all
facilityandfacilitiesproperties as deprecated, and deprecatesdata_source_equinix_metal_facility.Deprecation messages link to the facility-to-metro migration guide. That migration guide was updated in a separate PR to include a link to the facilities deprecation announcement.
Closes #312