docs: update docs to clarify that the IDs in user_ssh_key_ids are user IDs

[ctreatma]

Our documentation incorrectly stated that the IDs in user_ssh_key_ids for an equinix_metal_device were the IDs of the SSH keys that will be supported on the device; in reality they are the IDs of the users whose SSH keys will be supported.

In addition to the documentation, our tests were incorrectly attempting to pass an SSH key ID as a user ID, resulting in test failures due to errors from the API.

[ctreatma]

This fixes the 422 error from the API, but the test is currently checking that the device has 2 SSH keys, and that is an invalid expectation. It has every SSH key for the users specified in user_ssh_key_ids plus the 1 project SSH key specified in project_ssh_key_ids. I'm not really sure how to resolve this in a reliable way; can we instead check that the device SSH keys include the project and user SSH keys that were created as part of the test?

[ctreatma]

Test has been updated to confirm that the ssh_key_ids for the device include the IDs of the SSH keys that were created in the test: a3e2156#diff-b5bc3c33d7df2c76175fac51f0b7b4a5d4e2fd0268430d3b28091961885d775fR193-R204

[ctreatma]

Updated test passes: https://github.com/equinix/terraform-provider-equinix/actions/runs/5004498703/jobs/8967176160#step:5:3040

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.21 ⚠️

Comparison is base (d0a8ec6) 60.47% compared to head (a3e2156) 60.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   60.47%   60.27%   -0.21%     
==========================================
  Files          90       90              
  Lines       17940    17940              
==========================================
- Hits        10850    10813      -37     
- Misses       6793     6830      +37     
  Partials      297      297              

Impacted Files	Coverage Δ
equinix/resource_metal_device.go	72.33% <ø> (-1.31%)	⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[displague]

For reference:

• terraform-provider-equinix/equinix/resource_metal_device.go

  Lines 560 to 568 in b881163

  	projectKeys := d.Get("project_ssh_key_ids.#").(int)
  	if projectKeys > 0 {
  	createRequest.ProjectSSHKeys = convertStringArr(d.Get("project_ssh_key_ids").([]interface{}))
  	}
  	userKeys := d.Get("user_ssh_key_ids.#").(int)
  	if userKeys > 0 {
  	createRequest.UserSSHKeys = convertStringArr(d.Get("user_ssh_key_ids").([]interface{}))
  	}

• Metal Go Definitions: https://github.com/equinix-labs/metal-go/blob/808a44026f8c7fc4ca69a0a8f185cbf568259cad/spec/oas3.fetched/components/schemas/DeviceCreateInput.yaml#L121-L185

[displague]

Relates to #203