fix: Remove timeout for metal vrf #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to wait for a resource to reach a state
aayushrangwala
temporarily deployed
to
external
GitHub Actions
Inactive
7 tasks
ctreatma
reviewed
Sep 22, 2023
| ) | ||
|
|
||
| func resourceMetalVRF() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Timeouts: &schema.ResourceTimeout{ |
There was a problem hiding this comment.
This is removing timeouts entirely rather than fixing them. I don't necessarily think that's an issue: as I understand it, they didn't work and they weren't documented, so IMO it's just as valid to remove them as it is to make them work. However, if we're removing them, then the PR title should be updated to reflect that.
There was a problem hiding this comment.
Yes thats exactly correct, added the description in PR description as well
aayushrangwala
requested a deployment
to
external
GitHub Actions
Abandoned
aayushrangwala
changed the title
ctreatma
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of fixing the timeouts for metal resources to actually comply with what is documented, it was found out that we donot document any timeout support for metal VRF whereas in the code we do have support for timeouts.
Since it has never been working due to the below issue, also not documented, it'll be ideal to remove it directly considering a code smell
Relates to: #357