feat: Adding MultiCloud(FCR 2 AWS and Azure) Connection Example #409
Conversation
srushti-patl
commented
Oct 13, 2023
srushti-patl
commented
- Add Multi-cloud Connection example for FCR to AWS and Azure
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 59.56% 60.32% +0.76%
==========================================
Files 98 99 +1
Lines 19754 19889 +135
==========================================
+ Hits 11767 11999 +232
+ Misses 7684 7585 -99
- Partials 303 305 +2
☔ View full report in Codecov by Sentry. |
| } | ||
| } | ||
| output "azure_connection_azure" { | ||
| value = var.azure_connection_name |
There was a problem hiding this comment.
Nit: This should be grabbed from the created resource and not just directly from the input variable. It will be the same name but better to have it derived from the correct place.
| } | ||
|
|
||
| output "aws_connection_name" { | ||
| value = var.aws_connection_name |
There was a problem hiding this comment.
Same as comment about azure connection.
| @@ -0,0 +1,109 @@ | |||
| # ECX Fabric Layer2 MultiCloud Connection: FCR 2 AWS and Azure | |||
There was a problem hiding this comment.
Excellent PR, Srushti! Just had a couple of Nit comments on this. Be sure to add the variables.tf with this PR and then it will be ready to go.
