test: fabric_service_profile resource/data_source acceptance tests Feature/cxf 83390

[tutkat]

Added acceptance test for service profile

[codecov-commenter]

Codecov Report

Attention: 678 lines in your changes are missing coverage. Please review.

Comparison is base (a60c71f) 44.71% compared to head (1d862b8) 44.52%.
Report is 36 commits behind head on main.

Files	Patch %	Lines
equinix/resource_fabric_port.go	61.38%	139 Missing ⚠️
...ternal/resources/metal/project_ssh_key/resource.go	0.00%	131 Missing ⚠️
internal/resources/metal/ssh_key/resource.go	0.00%	130 Missing ⚠️
...rnal/resources/metal/project_ssh_key/datasource.go	0.00%	61 Missing ⚠️
...nternal/resources/metal/ssh_key/resource_schema.go	0.00%	45 Missing ⚠️
internal/resources/metal/vrf/resource.go	2.85%	34 Missing ⚠️
equinix/resource_fabric_connection.go	95.36%	26 Missing and 1 partial ⚠️
internal/resources/metal/project_ssh_key/models.go	0.00%	20 Missing ⚠️
internal/resources/metal/metal_connection/speed.go	0.00%	16 Missing ⚠️
equinix/fabric_mapping_helper.go	6.25%	15 Missing ⚠️
... and 10 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   44.71%   44.52%   -0.19%     
==========================================
  Files          98       98              
  Lines       19888    18866    -1022     
==========================================
- Hits         8893     8401     -492     
+ Misses      10961    10395     -566     
- Partials       34       70      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thogarty]

Good start, have requested changes to make. If you have questions add your comments to the PR for visibility.

[thogarty]

@tutkat , the PR needs to have a prefix in the name that labels what the release type is. For this it is test:, please update. Additionally, this is a public/customer facing repo. The Jira ticket name is not a readable description of what changed. Please label this PR test: fabric_service_profile resource/data_source acceptance tests

No release type found in pull request title "Feature/cxf 83390_tests". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

• feat: A new feature
• fix: A bug fix
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• refactor: A code change that neither fixes a bug nor adds a feature
• perf: A code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
• ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit

[thogarty]

More changes requested. Let me know if you have questions.

[thogarty]

Changes requested. Obvious bugs in PR. Please test after making changes to ensure correctness.

Additionally:

1. Please add a description to the PR so that it's clear what the change is without reading the code
2. Please update Names given to SPs. ds_con_sp_PFCR is unclear. Not sure what ds or con are referring two in either test sample.

[thogarty]

Changes requested. Please ensure you build and run tests after making changes so that your code is ready for a merge.

[thogarty]

Can confirm that service profile tests are working locally. Fabric GHA tests need some debugging and user data updates as well as sweeper changes before they will start passing again.

Approving change and merging.