feat: Include project id in client side filter for get accounts data source #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpdhulipala
changed the title
kpdhulipala
had a problem deploying
to
external
GitHub Actions
Failure
displague
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
This is optional client-side filtering of the equinix_network_account results based on a matching project_id. PR looks to do just that.
The field is added to the datasource documentation.
The test lines added verify that the datasource results now includes the project_id field.
What is not being tested is the filtering by project_id. The test isn't used in E2E testing, so it's hard to say how many results we would get back in the results. The code appears to be correct and I would expect the filter to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Include project id in client side filter for get accounts data source
PR in ne-go: equinix/ne-go#29
Closes the issue : #471