feat: push connection speed validation down to the API #610
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
===========================================
+ Coverage 41.74% 60.43% +18.69%
===========================================
Files 102 102
Lines 18551 18554 +3
===========================================
+ Hits 7745 11214 +3469
+ Misses 10600 6830 -3770
- Partials 206 510 +304 ☔ View full report in Codecov by Sentry. |
| @@ -50,7 +50,7 @@ func dataSourceSchema(ctx context.Context) schema.Schema { | |||
| Computed: true, | |||
| }, | |||
| "speed": schema.StringAttribute{ | |||
| Description: fmt.Sprintf("Port speed. Possible values are %s", allowedSpeedsString()), | |||
| Description: fmt.Sprintf("Port speed. Required for a_side connections. Values will be in the format '<number>Mbps' or '<number>Gpbs'"), | |||
There was a problem hiding this comment.
The .md should reflect the change. Perhaps we could give some examples speeds in the description.
There was a problem hiding this comment.
I updated the docs, but there was already some drift between the description in docs and the description in code; we probably should pick one and use it in both places, but which one to pick is an exercise left to the reviewer.
There was a problem hiding this comment.
For comparison:
- description in resource docs
- description in resource code
Went ahead and gave them the same description in docs and code.
ctreatma
force-pushed
the
shared-connection-vlans
branch
from
ab4e9d0 to
4870ab8
Compare
Previously, we maintained a list of valid connection speed values in the terraform provider in order to steer users towards selecting a valid connection speed. As shown by #595, validating values in the provider has the potential to break when the list of connection speed values supported by the API changes.
This updates the code that converts speed values between integer and string representations (i.e., the code that knows that
"50Mbps"is the same as500000000) to convert (roughly) arbitrary values. This means that new values are immediately "supported" by the provider, but it also means that invalid values will not be flagged until apply.The test change in this PR is sufficient to resolve the issue introduced by merging #605 without any other change to provider behavior.
Closes #609