Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle null MD5 in project BGP settings #632

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Mar 28, 2024

During the framework migration of the project resource, we missed that the framework-based resource doesn't correctly handle null values for the md5 attribute in BGP config.

This updates the basic project BGP test to cover that aspect of the project resource and updates the project model to avoid setting the in-state md5 value to "" when it should be nil.

Closes #630

@ctreatma ctreatma requested a review from a team as a code owner March 28, 2024 21:10
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 38.07%. Comparing base (42737f8) to head (8a051d2).

Files Patch % Lines
internal/resources/metal/project/models.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   38.07%   38.07%   -0.01%     
==========================================
  Files         120      120              
  Lines       19393    19394       +1     
==========================================
  Hits         7384     7384              
- Misses      11801    11802       +1     
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

md5 value checking and setting and added tests lgtm

relevant e2e tests pass

@ctreatma ctreatma merged commit 4d0b305 into main Mar 29, 2024
5 of 6 checks passed
@ctreatma ctreatma deleted the fix-metal-project-bgp branch March 29, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Provider produced inconsistent result after apply .bgp_config[0].md5 in equinix_metal_project
3 participants