feat: Inj_Valve_fix #113
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -112,16 +112,21 @@ def dataframe_tostring( | |||||
| Headers.END_MEASURED_DEPTH: "{:.3f}".format, | ||||||
| Headers.CV_DAR: "{:.10g}".format, | ||||||
| Headers.CV: "{:.10g}".format, | ||||||
| Headers.CV_INJV: "{:.10g}".format, | ||||||
| Headers.AC: "{:.3e}".format, | ||||||
| Headers.AC_OIL: "{:.3e}".format, | ||||||
| Headers.AC_GAS: "{:.3e}".format, | ||||||
| Headers.AC_WATER: "{:.3e}".format, | ||||||
| Headers.AC_PRIMARY: "{:.3e}".format, | ||||||
| Headers.AC_SECONDARY: "{:.3e}".format, | ||||||
| Headers.AC_MAX: "{:.3e}".format, | ||||||
| Headers.DEFAULTS: "{:.10s}".format, | ||||||
| Headers.WHF_LCF_DAR: "{:.10g}".format, | ||||||
| Headers.WHF_HCF_DAR: "{:.10g}".format, | ||||||
| Headers.GHF_LCF_DAR: "{:.10g}".format, | ||||||
| Headers.GHF_HCF_DAR: "{:.10g}".format, | ||||||
| Headers.WR_CF_INJV: "{:.10g}".format, | ||||||
| Headers.PRD_CF_INJV: "{:.10g}".format, | ||||||
| Headers.ALPHA_MAIN: "{:.10g}".format, | ||||||
| Headers.ALPHA_PILOT: "{:.10g}".format, | ||||||
| } | ||||||
|
|
@@ -438,9 +443,13 @@ def prepare_device_layer( | |||||
| df_well[Headers.DEVICE_TYPE] == "DAR", | ||||||
| "/ -- DAR types", | ||||||
| np.where( | ||||||
| df_well[Headers.DEVICE_TYPE] == "INJV", | ||||||
| "/ -- Injection Valve types", | ||||||
| np.where( | ||||||
| df_well[Headers.DEVICE_TYPE] == "AICV", | ||||||
| "/ -- AICV types", | ||||||
| np.where(df_well[Headers.DEVICE_TYPE] == "ICV", "/ -- ICV types", ""), | ||||||
|
There was a problem hiding this comment. This method should be re written! |
||||||
| ), | ||||||
| ), | ||||||
| ), | ||||||
| ), | ||||||
|
|
@@ -1190,6 +1199,42 @@ def prepare_wsegdar(well_name: str, lateral: int, df_well: pd.DataFrame, df_devi | |||||
| return wsegdar | ||||||
|
|
||||||
|
|
||||||
| def prepare_wseginjv(well_name: str, lateral: int, df_well: pd.DataFrame, df_device: pd.DataFrame) -> pd.DataFrame: | ||||||
| """Prepare data frame for Injection Valve. | ||||||
|
|
||||||
| Args: | ||||||
| well_name: Well name. | ||||||
|
There was a problem hiding this comment. Name of the well, maybe? |
||||||
| lateral: Lateral number. | ||||||
| df_well: df_well from class CreateWells. | ||||||
|
There was a problem hiding this comment. Not really describing |
||||||
| df_device: From function prepare_device_layer for this well and this lateral. | ||||||
|
|
||||||
| Returns: | ||||||
| DataFrame for Injection Valve. | ||||||
| """ | ||||||
| df_well = df_well[df_well[Headers.LATERAL] == lateral] | ||||||
|
There was a problem hiding this comment. Should be renamed, maybe to well_lateral or something |
||||||
| df_well = df_well[(df_well[Headers.DEVICE_TYPE] == "PERF") | (df_well[Headers.NUMBER_OF_DEVICES] > 0)] | ||||||
|
There was a problem hiding this comment. overwritten the last one, should be renamed, or remove the previous df_well definition |
||||||
| if df_well.shape[0] == 0: | ||||||
| return pd.DataFrame() | ||||||
|
There was a problem hiding this comment. returning an empty dataframe? |
||||||
| df_merge = pd.merge_asof( | ||||||
|
There was a problem hiding this comment. df_merge is not really a describing name, what is merge? |
||||||
| left=df_device, right=df_well, left_on=[Headers.MD], right_on=[Headers.TUB_MD], direction="nearest" | ||||||
| ) | ||||||
| df_merge = df_merge[df_merge[Headers.DEVICE_TYPE] == "INJV"] | ||||||
| wseginjv = pd.DataFrame() | ||||||
| if df_merge.shape[0] > 0: | ||||||
| wseginjv[Headers.WELL] = [well_name] * df_merge.shape[0] | ||||||
| wseginjv[Headers.SEG] = df_merge[Headers.SEG].to_numpy() | ||||||
| # the Cv is already corrected by the scaling factor | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| wseginjv[Headers.CV_INJV] = df_merge[Headers.CV_INJV].to_numpy() | ||||||
| wseginjv[Headers.AC_PRIMARY] = df_merge[Headers.AC_PRIMARY].to_numpy() | ||||||
| wseginjv[Headers.AC_SECONDARY] = df_merge[Headers.AC_SECONDARY].to_numpy() | ||||||
| wseginjv[Headers.WR_CF_INJV] = -1 * df_merge[Headers.WR_CF_INJV].to_numpy() | ||||||
| wseginjv[Headers.PRD_CF_INJV] = -1 * df_merge[Headers.PRD_CF_INJV].to_numpy() | ||||||
| wseginjv[Headers.DEFAULTS] = "5*" | ||||||
| wseginjv[Headers.AC_MAX] = wseginjv[Headers.AC_PRIMARY].to_numpy() | ||||||
| wseginjv[Headers.EMPTY] = "/" | ||||||
| return wseginjv | ||||||
|
|
||||||
|
|
||||||
| def prepare_wsegaicv(well_name: str, lateral: int, df_well: pd.DataFrame, df_device: pd.DataFrame) -> pd.DataFrame: | ||||||
| """Prepare data frame for AICV. | ||||||
|
|
||||||
|
|
@@ -1368,6 +1413,110 @@ def print_wsegdar(df_wsegdar: pd.DataFrame, well_number: int) -> str: | |||||
| return action | ||||||
|
|
||||||
|
|
||||||
| def print_wseginjv(df_wseginjv: pd.DataFrame, well_number: int) -> str: | ||||||
| """Print Injection Valves devices. | ||||||
|
|
||||||
| Args: | ||||||
| df_wseginjv: Output from function prepare_wseginjv. | ||||||
| well_number: Well number. | ||||||
|
|
||||||
| Returns: | ||||||
| Formatted actions to be included in the output file. | ||||||
|
|
||||||
| Raises: | ||||||
| CompletorError: If there are to many wells and/or segments with Injection Valve. | ||||||
| """ | ||||||
|
|
||||||
| """Important Information | ||||||
|
There was a problem hiding this comment. This should be included in the docstring. |
||||||
|
|
||||||
| -- the valves will react on both pressure drop and rate limit ---- | ||||||
| -- it will move to smaller nozzle, and back again if certain criteria is fulfilled --- | ||||||
| -- the SUVTRIG is a marker flag to check if it is on big nozzle or small nozzle -- | ||||||
| -- primary nozzle is 0 and secondary nozzle is 1 -- | ||||||
|
|
||||||
| """ | ||||||
|
|
||||||
| header = [ | ||||||
|
There was a problem hiding this comment. two list? primary headers, secondary? |
||||||
| [Headers.WELL, Headers.SEG, Headers.CV_INJV, Headers.AC_PRIMARY, Headers.DEFAULTS, Headers.AC_MAX], | ||||||
| [Headers.WELL, Headers.SEG, Headers.CV_INJV, Headers.AC_SECONDARY, Headers.DEFAULTS, Headers.AC_MAX], | ||||||
| ] | ||||||
| sign_rate = ["<"] | ||||||
|
There was a problem hiding this comment. Should not be a list, and the string should be written in directrly in the actions. Line 1479 |
||||||
| sign_pressure_drop = [">"] | ||||||
|
|
||||||
| suvtrig = ["0", "1"] | ||||||
|
There was a problem hiding this comment. I dont like this name, and should maybe used explisitt? 0 is easier than suvtrig[0] |
||||||
| action = "UDQ\n" | ||||||
| for idx in range(df_wseginjv.shape[0]): | ||||||
| segment_number = df_wseginjv[Headers.SEG].iloc[idx] | ||||||
| well_name = df_wseginjv[Headers.WELL].iloc[idx] | ||||||
| action += f" ASSIGN SUVTRIG {well_name} {segment_number} 0 /\n" | ||||||
| action += "/\n\n" | ||||||
| iaction = 1 | ||||||
|
There was a problem hiding this comment. Use the number 1 directly? |
||||||
| action += Keywords.WSEGVALV + "\n" | ||||||
| header_string = "--" | ||||||
| for itm in header[iaction]: | ||||||
| header_string += " " + itm | ||||||
| action += header_string.rstrip() + "\n" | ||||||
| for idx in range(df_wseginjv.shape[0]): | ||||||
| segment_number = df_wseginjv[Headers.SEG].iloc[idx] | ||||||
| print_df = df_wseginjv[df_wseginjv[Headers.SEG] == segment_number] | ||||||
| print_df = print_df[header[iaction]] | ||||||
| print_df = dataframe_tostring(print_df, True, False, False) + "\n" | ||||||
| action += print_df | ||||||
| action += "/\n\n" | ||||||
| for idx in range(df_wseginjv.shape[0]): | ||||||
| segment_number = df_wseginjv[Headers.SEG].iloc[idx] | ||||||
| well_name = df_wseginjv[Headers.WELL].iloc[idx] | ||||||
| water_segment_rate_cutoff = df_wseginjv[Headers.WR_CF_INJV].iloc[idx] | ||||||
| pressure_drop_cutoff = df_wseginjv[Headers.PRD_CF_INJV].iloc[idx] | ||||||
|
|
||||||
| iaction = 0 | ||||||
|
There was a problem hiding this comment. should not be set in every loop |
||||||
| act_number = iaction + 1 | ||||||
| act_name = f"INJVOP{well_number:03d}{segment_number:03d}{act_number:1d}" | ||||||
| if len(act_name) > 13: | ||||||
| raise CompletorError("Too many wells and/or too many segments with Injection Valve") | ||||||
| action += ( | ||||||
| f"ACTIONX\n{act_name} 1000000 /\n" | ||||||
| f"SWFR '{well_name}' {segment_number} " | ||||||
| f"{sign_rate[iaction]} {water_segment_rate_cutoff} AND /\n" | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| f"SUVTRIG '{well_name}' {segment_number} " | ||||||
| f"= {suvtrig[iaction]} /\n/\n\n" | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| ) | ||||||
| print_df = df_wseginjv[df_wseginjv[Headers.SEG] == segment_number] | ||||||
| print_df = print_df[header[iaction]] # type: ignore | ||||||
| header_string = Keywords.WSEGVALV + "\n--" | ||||||
| for item in header[iaction]: | ||||||
|
There was a problem hiding this comment. this loop seems unnecessary |
||||||
| header_string += " " + item | ||||||
| header_string = header_string.rstrip() + "\n" | ||||||
| print_df = header_string + dataframe_tostring(print_df, True, False, False) # type: ignore | ||||||
| print_df += "\n/\n" | ||||||
| print_df += f"\nUDQ\n ASSIGN SUVTRIG {well_name} {segment_number} 0 /\n/\n" | ||||||
| action += print_df + "\nENDACTIO\n\n" | ||||||
|
|
||||||
| iaction = 0 | ||||||
| act_number = iaction + 1 | ||||||
| act_name = f"INJVCL{well_number:03d}{segment_number:03d}{act_number:1d}" | ||||||
| if len(act_name) > 13: | ||||||
| raise CompletorError("Too many wells and/or too many segments with Injection Valve") | ||||||
| action += ( | ||||||
| f"ACTIONX\n{act_name} 1000000 /\n" | ||||||
| f"SPRD '{well_name}' {segment_number} " | ||||||
| f"{sign_pressure_drop[iaction]} {pressure_drop_cutoff} AND /\n" | ||||||
| f"SUVTRIG '{well_name}' {segment_number} " | ||||||
| f"= {suvtrig[iaction]} /\n/\n\n" | ||||||
| ) | ||||||
| print_df = df_wseginjv[df_wseginjv[Headers.SEG] == segment_number] | ||||||
| print_df = print_df[header[iaction]] # type: ignore | ||||||
| header_string = Keywords.WSEGVALV + "\n--" | ||||||
| for item in header[iaction]: | ||||||
| header_string += " " + item | ||||||
| header_string = header_string.rstrip() + "\n" | ||||||
| print_df = header_string + dataframe_tostring(print_df, True, False, False) # type: ignore | ||||||
| print_df += "\n/\n" | ||||||
| print_df += f"\nUDQ\n ASSIGN SUVTRIG {well_name} {segment_number} 1 /\n/\n" | ||||||
| action += print_df + "\nENDACTIO\n\n" | ||||||
|
|
||||||
| return action | ||||||
|
There was a problem hiding this comment. This function is a bit long |
||||||
|
|
||||||
|
|
||||||
| def print_wsegaicv(df_wsegaicv: pd.DataFrame, well_number: int) -> str: | ||||||
| """Print for AICV devices. | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make oneliner, ie:
'# rescale the CV, because there are no scaling factor in WSEGVALV.'
This can be done in all occasions or replace the three to one time at the top.