Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon issues #455

Closed
wenche opened this issue Sep 6, 2021 · 2 comments
Closed

Fix icon issues #455

wenche opened this issue Sep 6, 2021 · 2 comments
Assignees
@padms
Labels
🌐 Next.js (web) 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@wenche
Copy link
Contributor

wenche commented Sep 6, 2021 •
edited
Loading

We are still seeing some issues with icons on the static topic pages.

Skjermbilde 2021-09-06 kl. 11.53.20.png
@wenche wenche added 🌐 Next.js (web) 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base labels Sep 6, 2021
@padms padms self-assigned this Sep 7, 2021
padms added a commit that referenced this issue Sep 17, 2021
@padms
⬆️ Updated legacy styles #455 #458
23b73d2
@wenche
Copy link
Contributor Author

wenche commented Sep 20, 2021

Skjermbilde 2021-09-20 kl. 09.15.47.png
Looks good. :)

@padms It would be nice with a comment describing what you did beyond the linked commit.

@padms
Copy link
Contributor

padms commented Sep 21, 2021

This a bug in styled jsx, as a workaround , converted the equinor-icons.css to scss and then used unquote to set the glyph like here

@wenche wenche closed this as completed Sep 21, 2021
fernandolucchesi pushed a commit that referenced this issue Dec 1, 2021
@padms
⬆️ Updated legacy styles #455 #458
bf8a17f
@snyk-bot snyk-bot mentioned this issue Oct 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@padms padms

Labels
🌐 Next.js (web) 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wenche @padms