Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Remove pinning of fastapi<0.89 #236

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Remove pinning of fastapi<0.89 #236

merged 4 commits into from
Feb 24, 2023

Conversation

oysteoh
Copy link
Contributor

@oysteoh oysteoh commented Feb 17, 2023

starlette has been upgraded and compatible with newer versions of fastapi thus are we removing the pinning

Issue
Resolves #232

@oysteoh
Remove pinning of fastapi<0.89
282c447 
starlette has been upgraded and compatible with newer versions
of fastapi thus are we removing the pinning
@oysteoh oysteoh requested a review from andreas-el February 17, 2023 13:59
andreas-el
andreas-el approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@oysteoh oysteoh self-assigned this Feb 20, 2023
@andreas-el
Copy link
Contributor

andreas-el commented Feb 22, 2023 •
edited
Loading

I think this is related to the mypy version used.
On 0.990 i get no errors at all, but version 1.0.1 reports all kinds of issues.
This is obviously no remedy, so looking further.
Something was introduced in version 0.991 of mypy that triggers this.

@oysteoh
Copy link
Contributor Author

oysteoh commented Feb 23, 2023

In other repos ( i.e ERT ) we have .mypy config files ... Maybe we should introduce those here and add folders at least we don't want included ( like _alembic ) and also put up some other rules to get things through?

@oysteoh oysteoh merged commit 3ba0300 into equinor:main Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreas-el andreas-el andreas-el approved these changes

Assignees

@oysteoh oysteoh

Labels
None yet
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make compatible with fastapi>=0.89
2 participants
@oysteoh @andreas-el