Skip to content

Commit

Permalink
Remove filtering observations with std_cutoff
Browse files Browse the repository at this point in the history
  • Loading branch information
oyvindeide committed Aug 16, 2024
1 parent 5b268b4 commit 0dad1ac
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 0 additions & 2 deletions src/ert/config/ert_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,6 @@ def _create_observations(self) -> EnkfObs:
)
obs_config_content = parse(obs_config_file)
history = self.model_config.history_source
std_cutoff = self.analysis_config.observation_settings.std_cutoff
time_len = len(obs_time_list)
ensemble_config = self.ensemble_config
config_errors: List[ErrorInfo] = []
Expand All @@ -919,7 +918,6 @@ def _create_observations(self) -> EnkfObs:
ensemble_config,
values,
obs_name,
std_cutoff,
history,
time_len,
)
Expand Down
10 changes: 1 addition & 9 deletions src/ert/config/observations.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ def _handle_history_observation(
ensemble_config: "EnsembleConfig",
history_observation: HistoryValues,
summary_key: str,
std_cutoff: float,
history_type: HistorySource,
time_len: int,
) -> Dict[str, ObsVector]:
Expand Down Expand Up @@ -151,14 +150,7 @@ def _handle_history_observation(
segment_instance,
)
data: Dict[Union[int, datetime], Union[GenObservation, SummaryObservation]] = {}
for i, (date, error, value) in enumerate(zip(refcase.dates, std_dev, values)):
if error <= std_cutoff:
ConfigWarning.ert_context_warn(
"Too small observation error in observation"
f" {summary_key}:{i} - ignored",
summary_key,
)
continue
for date, error, value in zip(refcase.dates, std_dev, values):
data[date] = SummaryObservation(summary_key, summary_key, value, error)

return {
Expand Down

0 comments on commit 0dad1ac

Please sign in to comment.