Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate line nr and column when validating config #9527

Closed
oyvindeide opened this issue Dec 13, 2024 · 0 comments · Fixed by #9580
Closed

Propagate line nr and column when validating config #9527

oyvindeide opened this issue Dec 13, 2024 · 0 comments · Fixed by #9580
Assignees
Labels

Comments

@oyvindeide
Copy link
Collaborator

oyvindeide commented Dec 13, 2024

In Everest there is not tie back to the config file when the configuration is validated, however because we use ruyaml to parse the file, the line number and column information is already extracted and propagated. We should make sure that this is propagated all the way back to the user, take a modified math_func example:

adding:

simulator:
  queue_system: docal

will give:

everest run config_advanced.yml
usage: everest run <config_file> [arguments]
everest: error: Loading config file <config_advanced.yml> failed with:
Found  1 validation error:

simulator -> queue_system
    * Input should be 'lsf', 'local', 'slurm' or 'torque' (type=literal_error)

This should also give me the line in the config file where the error has occurred, and say which file this occurred in.

@oyvindeide oyvindeide moved this to Todo in SCOUT Dec 13, 2024
@frode-aarstad frode-aarstad moved this from Todo to In Progress in SCOUT Dec 13, 2024
@frode-aarstad frode-aarstad self-assigned this Dec 13, 2024
@frode-aarstad frode-aarstad moved this from In Progress to Ready for Review in SCOUT Dec 18, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in SCOUT Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants