Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line numbers when validating everest config files #9580

Merged

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #9527

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:improvement Automatically categorise as improvement in release notes label Dec 18, 2024
@frode-aarstad frode-aarstad self-assigned this Dec 18, 2024
@frode-aarstad frode-aarstad force-pushed the line-col-nr-during-validation branch from bc246ad to 5d997ad Compare December 18, 2024 08:30
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #9580 will improve performances by 10.64%

Comparing frode-aarstad:line-col-nr-during-validation (88025b6) with main (01156bb)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark main frode-aarstad:line-col-nr-during-validation Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] 2.6 ms 2.3 ms +10.64%

@frode-aarstad frode-aarstad force-pushed the line-col-nr-during-validation branch 3 times, most recently from fcf2804 to 0df8e47 Compare December 18, 2024 09:57
@frode-aarstad frode-aarstad force-pushed the line-col-nr-during-validation branch from 0df8e47 to 88025b6 Compare December 18, 2024 09:59
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (0e19012) to head (88025b6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/everest/config/everest_config.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9580      +/-   ##
==========================================
- Coverage   91.87%   91.85%   -0.02%     
==========================================
  Files         433      433              
  Lines       26770    26793      +23     
==========================================
+ Hits        24595    24612      +17     
- Misses       2175     2181       +6     
Flag Coverage Δ
cli-tests 39.75% <ø> (-0.01%) ⬇️
everest-models-test 34.61% <82.60%> (-0.05%) ⬇️
gui-tests 72.12% <ø> (-0.02%) ⬇️
integration-test 38.62% <82.60%> (+1.42%) ⬆️
performance-tests 51.94% <ø> (+<0.01%) ⬆️
test 39.83% <97.82%> (-0.62%) ⬇️
unit-tests 74.12% <28.26%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@verveerpj verveerpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One question out of curiosity.

src/everest/config/everest_config.py Show resolved Hide resolved
@frode-aarstad frode-aarstad merged commit 2e9c71a into equinor:main Dec 20, 2024
41 checks passed
@frode-aarstad frode-aarstad deleted the line-col-nr-during-validation branch December 20, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate line nr and column when validating config
3 participants