Fix an issue where summary dates are not precise enough #6897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
changed the title
eivindjahren
force-pushed
the
reimplement_eclsum_backup
branch
from
50664cb
to
ed6e059
Compare
eivindjahren
added
the
release-notes:bug-fix
eivindjahren
force-pushed
the
reimplement_eclsum_backup
branch
14 times, most recently
from
36ecd51
to
ae3c95d
Compare
eivindjahren
force-pushed
the
reimplement_eclsum_backup
branch
from
ae3c95d
to
97dcacf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6897 +/- ##
==========================================
+ Coverage 83.76% 84.16% +0.39%
==========================================
Files 368 368
Lines 21660 21860 +200
Branches 948 911 -37
==========================================
+ Hits 18144 18398 +254
+ Misses 3222 3168 -54
Partials 294 294 ☔ View full report in Codecov by Sentry. |
eivindjahren
changed the title
eivindjahren
force-pushed
the
reimplement_eclsum_backup
branch
4 times, most recently
from
acb42a8
to
8b27390
Compare
eivindjahren
force-pushed
the
reimplement_eclsum_backup
branch
from
8b27390
to
68fc26d
Compare
oyvindeide
approved these changes
Jan 10, 2024
| second_character = draw(st.sampled_from("OWGVLPT")) | ||
| third_character = draw(st.sampled_from("PIF")) | ||
| fourth_character = draw(st.sampled_from("RT")) | ||
| # local = draw(st.sampled_from(["", "L"])) if first_character in "BCW" else "" |
There was a problem hiding this comment.
Stray comment, something that is needed?
| try: | ||
| date_unit = DateUnit[unit_key] | ||
| except KeyError: | ||
| raise ValueError(f"Unknown date unit in {spec}: {unit_key}") from None |
There was a problem hiding this comment.
Why dont you want the context here?
There was a problem hiding this comment.
I think the keyerror is just misleading compared to the ValueError raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circumevents equinor/resdata#906 by reimlementing the summary reading with resfo. This also makes for a performance increase for summaries with many keys, but slightly worse performance (15%) for summaries with many dates.
This also ensures that float32 values are not converted in any way which removes precision loss. This also means that snapshots/reference values need to be updated.
When applicable