Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove run context #8271

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Remove run context #8271

merged 2 commits into from
Jul 31, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jul 1, 2024

Simplify some of the logic around RunContext, and instead of passing for example iteration to RunContext, it is taken from Ensemble, which owns it. It also means passing the Ensemble directly to functions instead of going through the RunContext

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the remove_run_context branch 2 times, most recently from b26de0a to e1e2b2a Compare July 1, 2024 13:37
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.00%. Comparing base (f529971) to head (ef21d65).

Files Patch % Lines
src/ert/run_models/iterated_ensemble_smoother.py 85.71% 1 Missing ⚠️
src/ert/run_models/multiple_data_assimilation.py 90.00% 1 Missing ⚠️
src/ert/simulator/batch_simulator_context.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8271       +/-   ##
===========================================
+ Coverage   55.25%   87.00%   +31.75%     
===========================================
  Files         378      377        -1     
  Lines       23954    23918       -36     
  Branches      618      626        +8     
===========================================
+ Hits        13235    20810     +7575     
+ Misses      10638     3035     -7603     
+ Partials       81       73        -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide force-pushed the remove_run_context branch 2 times, most recently from fdaa0bd to b7439f9 Compare July 2, 2024 09:58
@oyvindeide oyvindeide marked this pull request as ready for review July 2, 2024 11:55
@oyvindeide oyvindeide self-assigned this Jul 2, 2024
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jul 2, 2024
@oyvindeide oyvindeide force-pushed the remove_run_context branch 3 times, most recently from fb54d72 to ef21d65 Compare July 2, 2024 12:47
Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement I think 👍

@oyvindeide oyvindeide force-pushed the remove_run_context branch from ef21d65 to 7f9927e Compare July 31, 2024 08:23
@oyvindeide oyvindeide force-pushed the remove_run_context branch from 7f9927e to 935ed97 Compare July 31, 2024 10:12
@oyvindeide oyvindeide merged commit 7fc572d into equinor:main Jul 31, 2024
37 checks passed
@oyvindeide oyvindeide deleted the remove_run_context branch July 31, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants