Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid grid file raising uncaught exception #8352

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jul 26, 2024

Issue
Resolves #8351

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jul 26, 2024
@eivindjahren eivindjahren self-assigned this Jul 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (a51790c) to head (70d8c1a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8352   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         347      346    -1     
  Lines       21138    21094   -44     
=======================================
- Hits        18991    18952   -39     
+ Misses       2147     2142    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eivindjahren eivindjahren merged commit 08f449e into equinor:main Jul 26, 2024
37 checks passed
@eivindjahren eivindjahren deleted the fix_error_message_in_grid_file branch July 26, 2024 11:10
@eivindjahren eivindjahren mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show invalid grid file as ConfigValidationError
3 participants