Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move information about iteration #8366

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jul 31, 2024

Issue
Related to: #1250

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (7fc572d) to head (38eabc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8366      +/-   ##
==========================================
- Coverage   90.32%   90.31%   -0.01%     
==========================================
  Files         343      343              
  Lines       21006    21001       -5     
==========================================
- Hits        18973    18967       -6     
- Misses       2033     2034       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide self-assigned this Aug 1, 2024
@oyvindeide oyvindeide added the maintenance Not a bug now but could be one day, repaying technical debt label Aug 1, 2024
@oyvindeide oyvindeide marked this pull request as ready for review August 1, 2024 05:55
@sondreso sondreso added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 2, 2024
@oyvindeide oyvindeide merged commit 8928cd8 into equinor:main Aug 2, 2024
37 checks passed
@oyvindeide oyvindeide deleted the move_iteration branch August 2, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants