Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MOVE_DIRECTORY forward model job #8374

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Aug 2, 2024

Issue
Resolves #6060

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava added the feature label Aug 2, 2024
@DanSava DanSava self-assigned this Aug 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (e27780a) to head (0d475f3).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8374      +/-   ##
==========================================
+ Coverage   90.65%   90.88%   +0.22%     
==========================================
  Files         345      347       +2     
  Lines       21056    21076      +20     
==========================================
+ Hits        19088    19154      +66     
+ Misses       1968     1922      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fixup wrt comments on reformulating the docs to be a bit more clear/concise

@DanSava DanSava force-pushed the add_move_directory branch from fd8d695 to 0d475f3 Compare August 2, 2024 13:00
@DanSava DanSava merged commit cf02f45 into equinor:main Aug 2, 2024
37 checks passed
@DanSava DanSava deleted the add_move_directory branch August 2, 2024 13:27
DanSava added a commit to DanSava/ert that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOVE_DIRECTORY forward model job
3 participants