Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter popup not closing #8390

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #8380

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Aug 5, 2024
@frode-aarstad frode-aarstad self-assigned this Aug 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (50a9869) to head (a03c86d).
Report is 11 commits behind head on main.

Files Patch % Lines
src/ert/gui/tools/plot/filter_popup.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8390      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.01%     
==========================================
  Files         347      347              
  Lines       21076    21068       -8     
==========================================
- Hits        19154    19145       -9     
- Misses       1922     1923       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can still hang if we leave the filter window immediately after clicking the filter-button but I guess this is Qt thing.

@frode-aarstad frode-aarstad merged commit 7273944 into equinor:main Aug 6, 2024
37 checks passed
@frode-aarstad frode-aarstad deleted the fix-filter-hang branch August 6, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter by datatype hangs
3 participants