Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waiting cursor in load results manually panel #8393

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #7668

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Aug 6, 2024
@frode-aarstad frode-aarstad self-assigned this Aug 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.88%. Comparing base (7f39d51) to head (ade0209).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/ert/gui/tools/load_results/load_results_tool.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8393      +/-   ##
==========================================
+ Coverage   90.87%   90.88%   +0.01%     
==========================================
  Files         347      347              
  Lines       21068    21068              
==========================================
+ Hits        19145    19148       +3     
+ Misses       1923     1920       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda
Copy link
Contributor

dafeda commented Aug 6, 2024

The same window still seems to pop up but now there's no waiting-cursor. Is this the intention?

image

@frode-aarstad
Copy link
Contributor Author

The same window still seems to pop up but now there's no waiting-cursor. Is this the intention?

My interpretation of the issue was to remove the waiting cursor. Perhaps @andreas-el can clarify ?

@andreas-el
Copy link
Contributor

The same window still seems to pop up but now there's no waiting-cursor. Is this the intention?

My interpretation of the issue was to remove the waiting cursor. Perhaps @andreas-el can clarify ?

In the bug reported, I experienced that the system would try to load ensembles and fail (there were no ensembles to load).
There was a visual problem with the cursor indicating that more will happen if you wait.
The cursor will make sense as long as the system is actually processing, but should revert back to normal once loading comes to an end.

@frode-aarstad frode-aarstad merged commit 45b839b into equinor:main Aug 9, 2024
37 checks passed
@frode-aarstad frode-aarstad deleted the fix-load-results-cursor branch August 9, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load results ui elements indicate work is being done when processing has completed
4 participants