Add validation for num_realizations > 1 for analysis modules #8404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
added
the
release-notes:bug-fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8404 +/- ##
==========================================
+ Coverage 90.66% 90.83% +0.16%
==========================================
Files 347 347
Lines 21137 21145 +8
==========================================
+ Hits 19164 19207 +43
+ Misses 1973 1938 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
rebase to trigger rerun of semeio? |
|
Could there be something in the user documentation that needs to be updated following this change? |
I thought it is somewhat implicit ert knowledge. But you are right, I'll add it. |
oyvindeide
approved these changes
Aug 12, 2024
| if restart_run | ||
| else 0, | ||
| starting_iteration=( | ||
| storage.get_ensemble(prior_ensemble).iteration + 1 if restart_run else 0 |
There was a problem hiding this comment.
Just cosmetic? No problem for me, but suggest putting in a separate commit.
This adds validation to model_factor for active realizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8348
blocked by semeio testsshould be ok nowApproach
Inject validation where needed.
(Screenshot of new behavior in GUI if applicable)
When applicable