Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit numpy to one thread in heat equation #8429

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Aug 9, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (9ccd528) to head (d375a85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8429   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files         347      347           
  Lines       21123    21123           
=======================================
  Hits        19198    19198           
  Misses       1925     1925           
Flag Coverage Δ
gui-tests 76.16% <ø> (ø)
integration-tests 54.24% <ø> (-0.02%) ⬇️
unit-tests 68.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 🕵️

@dafeda dafeda force-pushed the heat-eq-num-threads branch from 4ba38ef to d375a85 Compare August 12, 2024 07:50
@dafeda dafeda merged commit ef5f5e2 into equinor:main Aug 12, 2024
37 checks passed
@dafeda dafeda deleted the heat-eq-num-threads branch August 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants