Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove current iteration and current label from run models #8453

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 13, 2024

This sentralizes the iteration number, meaning that we dont have to keep the (correct) state individually in all the run models.

Run label was not being used, it was only pased on when events were being sent, so set it explicitly there instead.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@oyvindeide oyvindeide changed the title Remove current iteration from run models Remove current iteration and current label from run models Aug 13, 2024
This had very little effect, as only the last one set before
the ensemble evaluater started was actully propagated to the gui
@oyvindeide oyvindeide force-pushed the remove_current_iteration branch from a61619c to 8a8b93d Compare August 13, 2024 13:30
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the extra commit as well!

@oyvindeide oyvindeide enabled auto-merge (rebase) August 13, 2024 13:34
@oyvindeide oyvindeide merged commit e0611cf into equinor:main Aug 13, 2024
35 checks passed
@oyvindeide oyvindeide deleted the remove_current_iteration branch August 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants