Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change look&feel of simulation mode combobox #8461

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 14, 2024

Checked on RGS, looks as intended there too. ✅

Was:
Screenshot 2024-08-14 at 14 01 37

Change:

Screenshot 2024-08-14 at 13 55 19 Screenshot 2024-08-14 at 13 55 09
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el self-assigned this Aug 14, 2024
@eivindjahren eivindjahren added the release-notes:improvement Automatically categorise as improvement in release notes label Aug 14, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andreas-el andreas-el merged commit c27d368 into equinor:main Aug 14, 2024
35 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (83ec3c4) to head (a9bbea8).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/ert/gui/ertwidgets/combobox_with_description.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8461      +/-   ##
==========================================
- Coverage   90.68%   90.67%   -0.02%     
==========================================
  Files         346      346              
  Lines       21013    21018       +5     
==========================================
+ Hits        19056    19058       +2     
- Misses       1957     1960       +3     
Flag Coverage Δ
gui-tests 75.92% <42.85%> (+0.02%) ⬆️
integration-tests 53.98% <42.85%> (-0.01%) ⬇️
unit-tests 68.71% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants