Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and deprecated queue_options #8471

Merged

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Aug 15, 2024

Issue
Resolves #8463
Resolves #8441
Resolves #8442

Approach
✂️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq self-assigned this Aug 15, 2024
@jonathan-eq jonathan-eq added maintenance Not a bug now but could be one day, repaying technical debt release-notes:maintenance Automatically categorise as maintenance change in release notes labels Aug 15, 2024
@jonathan-eq jonathan-eq force-pushed the remove-depecated-queue-options branch from 7970363 to 8ffbab0 Compare August 15, 2024 10:44
@jonathan-eq jonathan-eq force-pushed the remove-depecated-queue-options branch from 8ffbab0 to bef1a42 Compare August 15, 2024 10:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (acfc8c9) to head (bef1a42).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8471      +/-   ##
==========================================
- Coverage   90.82%   90.67%   -0.16%     
==========================================
  Files         348      346       -2     
  Lines       21143    21022     -121     
==========================================
- Hits        19204    19061     -143     
- Misses       1939     1961      +22     
Flag Coverage Δ
gui-tests 75.91% <ø> (-0.24%) ⬇️
integration-tests 53.97% <ø> (-0.22%) ⬇️
unit-tests 68.69% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@jonathan-eq jonathan-eq merged commit 73b2710 into equinor:main Aug 16, 2024
35 checks passed
@jonathan-eq jonathan-eq deleted the remove-depecated-queue-options branch August 16, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
3 participants