Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analyis iter config #8472

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 15, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

self._update_log_path = Path(update_log_path)
self._min_realization = min_realization
self.num_iterations = num_iterations
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit annoying, as we dont know it up front, and it is only used in the export run_path workflow, and the state is kept in sync in BaseRunModel, not ideal. An option is to add a fixture which says the number of iterations, which will be more correct, but also add more over head. Not sure what the best action is.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (fb702fb) to head (ffc07dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8472      +/-   ##
==========================================
+ Coverage   90.67%   90.68%   +0.01%     
==========================================
  Files         346      345       -1     
  Lines       21022    20981      -41     
==========================================
- Hits        19061    19026      -35     
+ Misses       1961     1955       -6     
Flag Coverage Δ
gui-tests 75.92% <100.00%> (+0.03%) ⬆️
integration-tests 53.95% <50.00%> (-0.03%) ⬇️
unit-tests 68.67% <62.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide self-assigned this Aug 15, 2024
@oyvindeide oyvindeide added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Aug 15, 2024
@oyvindeide oyvindeide merged commit aad5994 into equinor:main Aug 15, 2024
35 checks passed
@oyvindeide oyvindeide deleted the remove_iter_config branch August 15, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants